fix(renderer): make light glare visible without light markers #1000

Merged
SakulFlee merged 1 commit from fix/bloom-hdr-feedback into main 2026-10-31 03:23:13 +00:00
Owner

Summary

  • Remove the HDR light-source billboards/orbs from All-in-One.
  • Generate screen-space glare directly from visible point and spot lights in the tonemap pass.
  • Occlude that glare against the scene depth buffer, so lights behind walls do not leak through.
  • Lower the All-in-One volumetric fog density and raise the scene bloom threshold to remove the flat haze.
  • Log exposure/bloom changes so setting application can be verified from the console.

Notes

  • The glare appears around point/spot lights that are on screen and not behind opaque geometry; looking directly into a light now produces a bright core and halo without a visible marker mesh.
  • The scene-highlight threshold is separate from the positional light glare; light glare strength is controlled by Intensity.
  • Local headless tests cover shader compilation, glare-light extraction, and tonemap parameter packing.
## Summary - Remove the HDR light-source billboards/orbs from All-in-One. - Generate screen-space glare directly from visible point and spot lights in the tonemap pass. - Occlude that glare against the scene depth buffer, so lights behind walls do not leak through. - Lower the All-in-One volumetric fog density and raise the scene bloom threshold to remove the flat haze. - Log exposure/bloom changes so setting application can be verified from the console. ## Notes - The glare appears around point/spot lights that are on screen and not behind opaque geometry; looking directly into a light now produces a bright core and halo without a visible marker mesh. - The scene-highlight threshold is separate from the positional light glare; light glare strength is controlled by Intensity. - Local headless tests cover shader compilation, glare-light extraction, and tonemap parameter packing.
fix(renderer): derive light glare from visible light sources
Some checks failed
Lint / lint (pull_request) Successful in 3m22s
PR / test (pull_request) Has been cancelled
Templates / templates (pull_request) Has been cancelled
569caf8206
SakulFlee force-pushed fix/bloom-hdr-feedback from 569caf8206
Some checks failed
Lint / lint (pull_request) Successful in 3m22s
PR / test (pull_request) Has been cancelled
Templates / templates (pull_request) Has been cancelled
to 40fda42eb4
All checks were successful
Lint / lint (pull_request) Successful in 2m28s
PR / test (pull_request) Successful in 7m22s
Templates / templates (pull_request) Successful in 5m6s
2026-10-31 03:06:15 +00:00
Compare

Smart test results

Result: PASS

Scope: orbital_app, orbital_debug_ui, orbital_renderer

Reason: directly changed crates

Elapsed: 4m 38s

Workflow run

Overall: 80 tests, 78 passed, 0 failed, 2 skipped

Nextest: 78 tests, 78 passed, 0 failed, 0 skipped
Doctests: 2 tests, 0 passed, 0 failed, 2 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 10 10 0 0 0/1 0.05s
orbital_debug_ui 48 48 0 0 0/1 0.29s
orbital_renderer 20 20 0 0 - 0.24s
pie showData
    title Nextest outcomes
    "Passed" : 78
pie showData
    title Doctest outcomes
    "Skipped" : 2
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_debug_ui", "orbital_renderer", "orbital_app"]
    y-axis "Seconds" 0 --> 1
    bar [0.29, 0.24, 0.05]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_debug_ui, orbital_renderer **Reason:** directly changed crates **Elapsed:** 4m 38s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/934) **Overall:** 80 tests, 78 passed, 0 failed, 2 skipped **Nextest:** 78 tests, 78 passed, 0 failed, 0 skipped **Doctests:** 2 tests, 0 passed, 0 failed, 2 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 10 | 10 | 0 | 0 | 0/1 | 0.05s | | orbital_debug_ui | 48 | 48 | 0 | 0 | 0/1 | 0.29s | | orbital_renderer | 20 | 20 | 0 | 0 | - | 0.24s | ```mermaid pie showData title Nextest outcomes "Passed" : 78 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 2 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_debug_ui", "orbital_renderer", "orbital_app"] y-axis "Seconds" 0 --> 1 bar [0.29, 0.24, 0.05] ```
SakulFlee force-pushed fix/bloom-hdr-feedback from 40fda42eb4
All checks were successful
Lint / lint (pull_request) Successful in 2m28s
PR / test (pull_request) Successful in 7m22s
Templates / templates (pull_request) Successful in 5m6s
to d33b1dc6e9
All checks were successful
Lint / lint (pull_request) Successful in 1m52s
Templates / templates (pull_request) Successful in 2m22s
PR / test (pull_request) Successful in 5m12s
2026-10-31 03:16:23 +00:00
Compare
SakulFlee referenced this pull request from a commit 2026-10-31 03:23:14 +00:00
Sign in to join this conversation.
No description provided.