fix(iced): update the fork for touch scrolling over widgets #1126

Merged
SakulFlee merged 1 commit from sakulflee/issue-1125 into main 2026-11-14 03:01:08 +00:00 AGit
Owner

Android touch scrolling in a Scrollable currently only works over empty space: buttons, checkboxes and sliders capture the touch press, so the scrollable never starts scrolling and the widget activates instead. This picks up the Orbital-Iced fix that defers the press until the gesture is classified: taps are replayed to the widget, drags along the scroll axis scroll without activating it, and cross-axis drags are handed to the widget. Depends on SakulFlee/Orbital-Iced#26. Verified on a physical Mali-G720 device: swiping over ECS row buttons and panel text scrolls, taps still open rows and toggle checkboxes, and the scroll direction matches the previous behavior. Fixes #1125. Closes #1125.

Android touch scrolling in a Scrollable currently only works over empty space: buttons, checkboxes and sliders capture the touch press, so the scrollable never starts scrolling and the widget activates instead. This picks up the Orbital-Iced fix that defers the press until the gesture is classified: taps are replayed to the widget, drags along the scroll axis scroll without activating it, and cross-axis drags are handed to the widget. Depends on SakulFlee/Orbital-Iced#26. Verified on a physical Mali-G720 device: swiping over ECS row buttons and panel text scrolls, taps still open rows and toggle checkboxes, and the scroll direction matches the previous behavior. Fixes #1125. Closes #1125.
fix(iced): update the fork for touch scrolling over widgets
All checks were successful
Lint / lint (pull_request) Successful in 1m46s
Templates / templates (pull_request) Successful in 5m7s
PR / test (pull_request) Successful in 15m19s
3c0f52ddf6

Smart test results

Result: PASS

Scope: full workspace

Reason: workspace-level change: Cargo.lock

Elapsed: 14m 30s

Workflow run

Overall: 567 tests, 557 passed, 0 failed, 10 skipped

Nextest: 556 tests, 556 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital 1 1 0 0 - 0.64s
orbital-cli 3 3 0 0 - 0.02s
orbital_2d 29 29 0 0 0/1 0.16s
orbital_app 25 25 0 0 0/1 0.13s
orbital_billboard 14 14 0 0 - 4.14s
orbital_camera 8 8 0 0 - 0.04s
orbital_core 2 2 0 0 - 0.01s
orbital_debug_render 2 2 0 0 0/1 0.01s
orbital_debug_ui 67 67 0 0 0/1 0.45s
orbital_ecs 114 114 0 0 0/2 0.67s
orbital_ecs_bridge 50 50 0 0 - 0.30s
orbital_file_manager 5 5 0 0 - 0.03s
orbital_iced 30 30 0 0 - 0.16s
orbital_importer_gltf 16 16 0 0 - 0.17s
orbital_input 11 11 0 0 - 0.06s
orbital_light 8 8 0 0 - 0.05s
orbital_macros 0 0 0 0 0/1 0.00s
orbital_material_shader 2 2 0 0 - 0.02s
orbital_math 4 4 0 0 - 0.03s
orbital_mesh 2 2 0 0 - 0.01s
orbital_procgeo 3 3 0 0 - 0.02s
orbital_render_graph 6 6 0 0 - 0.04s
orbital_renderer 28 28 0 0 - 0.29s
orbital_resources 29 29 0 0 - 0.21s
orbital_shader_core 0 0 0 0 1/1 0.00s
orbital_shader_pbr 4 4 0 0 - 0.03s
orbital_shader_preprocessor 12 12 0 0 - 0.07s
orbital_shadow 3 3 0 0 - 0.01s
orbital_text 15 15 0 0 0/1 0.46s
orbital_texture 11 11 0 0 - 0.06s
orbital_touch_ui 1 1 0 0 0/1 0.01s
orbital_ui 32 32 0 0 0/1 0.21s
orbital_world_environment 13 13 0 0 - 0.08s
template_all_in_one 6 6 0 0 - 0.03s
pie showData
    title Nextest outcomes
    "Passed" : 556
pie showData
    title Doctest outcomes
    "Passed" : 1
    "Skipped" : 10
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_billboard", "orbital_ecs", "orbital", "orbital_text", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_renderer", "orbital_resources"]
    y-axis "Seconds" 0 --> 4.2
    bar [4.14, 0.67, 0.64, 0.46, 0.45, 0.30, 0.29, 0.21]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** full workspace **Reason:** workspace-level change: Cargo.lock **Elapsed:** 14m 30s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/1410) **Overall:** 567 tests, 557 passed, 0 failed, 10 skipped **Nextest:** 556 tests, 556 passed, 0 failed, 0 skipped **Doctests:** 11 tests, 1 passed, 0 failed, 10 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital | 1 | 1 | 0 | 0 | - | 0.64s | | orbital-cli | 3 | 3 | 0 | 0 | - | 0.02s | | orbital_2d | 29 | 29 | 0 | 0 | 0/1 | 0.16s | | orbital_app | 25 | 25 | 0 | 0 | 0/1 | 0.13s | | orbital_billboard | 14 | 14 | 0 | 0 | - | 4.14s | | orbital_camera | 8 | 8 | 0 | 0 | - | 0.04s | | orbital_core | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_debug_render | 2 | 2 | 0 | 0 | 0/1 | 0.01s | | orbital_debug_ui | 67 | 67 | 0 | 0 | 0/1 | 0.45s | | orbital_ecs | 114 | 114 | 0 | 0 | 0/2 | 0.67s | | orbital_ecs_bridge | 50 | 50 | 0 | 0 | - | 0.30s | | orbital_file_manager | 5 | 5 | 0 | 0 | - | 0.03s | | orbital_iced | 30 | 30 | 0 | 0 | - | 0.16s | | orbital_importer_gltf | 16 | 16 | 0 | 0 | - | 0.17s | | orbital_input | 11 | 11 | 0 | 0 | - | 0.06s | | orbital_light | 8 | 8 | 0 | 0 | - | 0.05s | | orbital_macros | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_material_shader | 2 | 2 | 0 | 0 | - | 0.02s | | orbital_math | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_mesh | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_procgeo | 3 | 3 | 0 | 0 | - | 0.02s | | orbital_render_graph | 6 | 6 | 0 | 0 | - | 0.04s | | orbital_renderer | 28 | 28 | 0 | 0 | - | 0.29s | | orbital_resources | 29 | 29 | 0 | 0 | - | 0.21s | | orbital_shader_core | 0 | 0 | 0 | 0 | 1/1 | 0.00s | | orbital_shader_pbr | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_shader_preprocessor | 12 | 12 | 0 | 0 | - | 0.07s | | orbital_shadow | 3 | 3 | 0 | 0 | - | 0.01s | | orbital_text | 15 | 15 | 0 | 0 | 0/1 | 0.46s | | orbital_texture | 11 | 11 | 0 | 0 | - | 0.06s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.01s | | orbital_ui | 32 | 32 | 0 | 0 | 0/1 | 0.21s | | orbital_world_environment | 13 | 13 | 0 | 0 | - | 0.08s | | template_all_in_one | 6 | 6 | 0 | 0 | - | 0.03s | ```mermaid pie showData title Nextest outcomes "Passed" : 556 ``` ```mermaid pie showData title Doctest outcomes "Passed" : 1 "Skipped" : 10 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_billboard", "orbital_ecs", "orbital", "orbital_text", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_renderer", "orbital_resources"] y-axis "Seconds" 0 --> 4.2 bar [4.14, 0.67, 0.64, 0.46, 0.45, 0.30, 0.29, 0.21] ```
Sign in to join this conversation.
No description provided.