SakulFlee/Orbital
1
0
Fork 0
Code Issues 51 Pull requests 24 Projects Releases 1 Packages Wiki Activity

Shader output should not be printed out in logs #610

New issue
Open
opened 2026-01-07 01:55:57 +01:00 by SakulFlee · 0 comments
SakulFlee commented 2026-01-07 01:55:57 +01:00
Owner
Copy link

When shaders are compiled, the full shader source code is printed to the log output. This clutters logs and may expose internal implementation details. Shader compilation output should be suppressed by default, with an opt-in debug flag to enable logging it when needed.

Acceptance criteria:

  • Shader source not printed to info/debug logs by default
  • Add a ShaderConfig::log_shader_source flag or similar opt-in
  • Compilation errors should still be reported
When shaders are compiled, the full shader source code is printed to the log output. This clutters logs and may expose internal implementation details. Shader compilation output should be suppressed by default, with an opt-in debug flag to enable logging it when needed. **Acceptance criteria:** - Shader source not printed to `info`/`debug` logs by default - Add a `ShaderConfig::log_shader_source` flag or similar opt-in - Compilation errors should still be reported
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ui-primer
feat_ibl_generation
renovate/com.android.library-9.x
renovate/ulid-3.x
test_ci_new
fix_ci
test_ci
perf/shader-distance-cull
perf/shadow-slot-earlyout
perf/logging-cleanup
perf/bind-group-cache
perf/timing-instrumentation
fix_light_optimization
fix_windows_ibl_gen
fix_ibl_gen
fix_windows_build
lights_and_shadows
improve_bootstrap
procgeo
refactor/deduplicate-block-on
Orbital_frustum_culling
refactor/gltf-texture-take-by-value
perf/cache-shader-preprocessor
fix/error-display-println
cleanup/error-display-println
fix/panic-to-result
cleanup/panic-to-result
cleanup/configurable-shader-paths
refactor/configurable-shader-paths
cleanup/library-panic-to-result
fix/channel-send-error-log
fix/duplicate-frame-latency-assignment
perf/render-slice-argument
perf/light-descriptor-fixed-array
perf/texture-pixel-direct-write
perf/input-state-swap
perf/environment-realize-once
perf/realize-hoist-store-locks
perf/importer-vecdeque
perf/shader-preprocessor-push-str
fix/texture-size-mismatch-error
fix/gltf-index-iterator-double-consume
fix/gltf-camera-far-near
ci_caching
ecs_migration
ci_windows
fix/ci-pull_request-trigger
test_adapter_failure
fix/vsync-present-mode
woodpecker-ci-upgrade
sharding
enable-vsync-by-default-in-examples
ecs_trial
readme-update
531/merge
SakulFlee/issue326
v2025.10.2
2025.10.1
v2025.10.1
v2025.7.1
Labels
Clear labels   
Context: Async
Async specific, be it bug or feature

  
Context: Bug
Something isn't working as intended

  
Context: CI
GitHub Actions / CI related tasks

  
Context: Dependencies
Pull requests that update a dependency file

  
Context: Documentation
Improvements or additions to documentation

  
Context: Enhancement
New feature or request

  
Context: Example
Example related issues

  
Context: Macro

   
Context: Runtime
Runtime related issues

  
Difficulty: Easy

   
Difficulty: Hard

   
Difficulty: Medium

   
Platform: Android
ONLY if this is platform specific!

  
Platform: iOS
ONLY if this is platform specific!

  
Platform: Linux
ONLY if this is platform specific!

  
Platform: macOS
ONLY if this is platform specific!

  
Platform: Web
ONLY if this is platform specific!

  
Platform: Windows
ONLY if this is platform specific!

  
Type: Discussion

   
Type: Evaluation
Further evaluation is needed

  
Type: Tracker
Issues acting as trackers; I.e. a combination of issues of the same overall topic.

No labels
Context: Async
Context: Bug
Context: CI
Context: Dependencies
Context: Documentation
Context: Enhancement
Context: Example
Context: Macro
Context: Runtime
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Platform: Android
Platform: iOS
Platform: Linux
Platform: macOS
Platform: Web
Platform: Windows
Type: Discussion
Type: Evaluation
Type: Tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
SakulFlee
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SakulFlee/Orbital#610
No description provided.