AppRuntime::resumed state check condition is always true — spurious warnings #670

New issue

Open

opened 2026-07-05 03:22:38 +02:00 by Hermes · 0 comments

Hermes commented

2026-07-05 03:22:38 +02:00

Collaborator

Severity: 🟡 Medium

File: Crates/orbital_app/src/runtime.rs:214

Bug:
The guard condition uses || (OR) when it should use && (AND), making it always evaluate to true:

fn resumed(&mut self, event_loop: &ActiveEventLoop) {
    if !matches!(self.state, AppState::Starting) || !matches!(self.state, AppState::Paused) {
        debug!(
            "Attempting to resume while not in required state! (State: {:?})",
            self.state
        );
    }

If state is Starting: !Starting = false, but !Paused = true → overall: true (spurious warning).
If state is Paused: !Starting = true → overall: true (spurious warning).
If state is anything else: both are true.

Impact: The debug warning fires on every resume even in valid states.

Fix: Change || to &&.

@SakulFlee

**Severity:** 🟡 Medium **File:** `Crates/orbital_app/src/runtime.rs:214` **Bug:** The guard condition uses `||` (OR) when it should use `&&` (AND), making it **always evaluate to `true`**: ```rust fn resumed(&mut self, event_loop: &ActiveEventLoop) { if !matches!(self.state, AppState::Starting) || !matches!(self.state, AppState::Paused) { debug!( "Attempting to resume while not in required state! (State: {:?})", self.state ); } ``` If state is `Starting`: `!Starting = false`, but `!Paused = true` → overall: `true` (spurious warning). If state is `Paused`: `!Starting = true` → overall: `true` (spurious warning). If state is anything else: both are `true`. **Impact:** The debug warning fires on **every** resume even in valid states. **Fix:** Change `||` to `&&`. @SakulFlee

Hermes added the

Context: Bug

Difficulty: Easy

labels

2026-07-05 03:22:38 +02:00