refactor(renderer): extract render scene and own frame resources #933
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!933
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/renderer-phase-1"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Phase 1 of the renderer overhaul (#781): move the ECS-to-GPU extraction boundary into
orbital_rendererand make the renderer own its frame resources.orbital_renderer::RenderScene/RenderCameraas an owned snapshot of the active camera, realized models, light buffer, environment, shadow lights and light count.ModuleRuntime, removing the raw model-pointer collection and the staticOnceLockfallbacks.Renderer.ShadowRenderer::renderto acceptArc<Model>so no temporaryVec<&Model>is needed.Renderer::camera_buffer(&RenderScene)for overlays.orbital_ecs_bridgebuilds, matchingorbital_iced's Linux target section.RenderSceneis deliberately the animation extension point: bone matrices and previous-frame transforms can be added there without touching the render passes. This change is behavior-preserving; single-submit recording and persistent buffer reuse follow in the next phase-1 changes.Verification
cargo fmt --all -- --checkcargo clippy -p orbital_renderer -p orbital_shadow -p orbital_app -p orbital_iced -- -D warningscargo test -p orbital_renderer -p orbital_shadow -p orbital_app -p orbital_iced --no-fail-fastcargo test -p orbital_renderer --no-fail-fastcargo check -p template_minimal -p template_all_in_one -p template_2dRefs #781.
Smart test results
Result: PASS
Scope: full workspace
Reason: workspace-level change: Cargo.lock
Elapsed: 10m 27s
Workflow run
Overall: 417 tests, 407 passed, 0 failed, 10 skipped
Nextest: 406 tests, 406 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.
e7a14bd9370e713ed05f