fix(volumetrics): distribute froxel slices by view depth #976
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!976
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/volumetric-linear-depth"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Fixes the froxel depth distribution.
The volumetric grid was addressing slices directly with NDC depth. With a typical near plane of
0.1and a far plane of10000, almost every slice ended up in the first few centimetres/metres of the view, so room-distance fog and spot cones were severely undersampled. That explains why cones appeared only at specific camera angles, why quality changes looked so different, and why low quality produced isolated blobs.Changes:
Validation
cargo test -p orbital_renderer -p orbital_debug_ui --all-targetspasses, including the noop volumetric pipelines.cargo check --workspacewith the workspace clippy driver and-D warningspasses.rustfmt --checkpasses.Related: #975, #971.
Smart test results
Result: PASS
Scope: orbital_debug_ui, orbital_renderer
Reason: directly changed crates
Elapsed: 3m 19s
Workflow run
Overall: 66 tests, 65 passed, 0 failed, 1 skipped
Nextest: 65 tests, 65 passed, 0 failed, 0 skipped
Doctests: 1 tests, 0 passed, 0 failed, 1 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.