fix(iced): disable a panel when pipeline creation fails #1063

Merged
SakulFlee merged 1 commit from fix/iced-init-fallback into main 2026-11-06 21:17:04 +00:00
Owner

On Android the iced quad pipeline reports InvalidResource even after the surface-format timing fix, and the runtime then submits the invalid pipeline every frame. That can stall the app and hides the real initialization error.

This wraps iced renderer creation in a validation error scope. If pipeline creation fails, it logs the actual validation error once, marks that panel failed, and skips it. A later surface-format change resets the flag and retries. This keeps the app responsive and lets performance CSV capture continue while the Android iced backend issue is investigated.

This is a safety/diagnostic fallback, not the final Android iced fix. It should make the phone boot and produce a single actionable pipeline-creation error instead of an error loop.

Refs #1061.

On Android the iced quad pipeline reports `InvalidResource` even after the surface-format timing fix, and the runtime then submits the invalid pipeline every frame. That can stall the app and hides the real initialization error. This wraps iced renderer creation in a validation error scope. If pipeline creation fails, it logs the actual validation error once, marks that panel failed, and skips it. A later surface-format change resets the flag and retries. This keeps the app responsive and lets performance CSV capture continue while the Android iced backend issue is investigated. This is a safety/diagnostic fallback, not the final Android iced fix. It should make the phone boot and produce a single actionable pipeline-creation error instead of an error loop. Refs #1061.
fix(iced): disable a panel when pipeline creation fails
All checks were successful
Lint / lint (pull_request) Successful in 1m20s
Templates / templates (pull_request) Successful in 5m25s
PR / test (pull_request) Successful in 19m4s
5462206648

Smart test results

Result: PASS

Scope: full workspace

Reason: workspace-level change: Cargo.lock

Elapsed: 18m 22s

Workflow run

Overall: 516 tests, 506 passed, 0 failed, 10 skipped

Nextest: 505 tests, 505 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital 1 1 0 0 - 0.70s
orbital-cli 3 3 0 0 - 0.05s
orbital_2d 29 29 0 0 0/1 0.17s
orbital_app 19 19 0 0 0/1 0.11s
orbital_billboard 9 9 0 0 - 0.22s
orbital_camera 8 8 0 0 - 0.05s
orbital_core 2 2 0 0 - 0.01s
orbital_debug_render 2 2 0 0 0/1 0.01s
orbital_debug_ui 50 50 0 0 0/1 0.29s
orbital_ecs 114 114 0 0 0/2 0.65s
orbital_ecs_bridge 45 45 0 0 - 0.27s
orbital_file_manager 5 5 0 0 - 0.03s
orbital_iced 26 26 0 0 - 0.15s
orbital_importer_gltf 16 16 0 0 - 0.15s
orbital_input 11 11 0 0 - 0.05s
orbital_light 6 6 0 0 - 0.03s
orbital_macros 0 0 0 0 0/1 0.00s
orbital_material_shader 2 2 0 0 - 0.01s
orbital_math 4 4 0 0 - 0.02s
orbital_mesh 2 2 0 0 - 0.01s
orbital_procgeo 3 3 0 0 - 0.01s
orbital_render_graph 6 6 0 0 - 0.03s
orbital_renderer 21 21 0 0 - 0.19s
orbital_resources 29 29 0 0 - 0.20s
orbital_shader_core 0 0 0 0 1/1 0.00s
orbital_shader_pbr 4 4 0 0 - 0.02s
orbital_shader_preprocessor 12 12 0 0 - 0.05s
orbital_shadow 3 3 0 0 - 0.01s
orbital_text 14 14 0 0 0/1 0.30s
orbital_texture 11 11 0 0 - 0.05s
orbital_touch_ui 1 1 0 0 0/1 0.01s
orbital_ui 32 32 0 0 0/1 0.16s
orbital_world_environment 13 13 0 0 - 0.08s
template_all_in_one 2 2 0 0 - 0.01s
pie showData
    title Nextest outcomes
    "Passed" : 505
pie showData
    title Doctest outcomes
    "Passed" : 1
    "Skipped" : 10
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital", "orbital_ecs", "orbital_text", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_billboard", "orbital_resources", "orbital_renderer"]
    y-axis "Seconds" 0 --> 1
    bar [0.70, 0.65, 0.30, 0.29, 0.27, 0.22, 0.20, 0.19]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** full workspace **Reason:** workspace-level change: Cargo.lock **Elapsed:** 18m 22s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/1176) **Overall:** 516 tests, 506 passed, 0 failed, 10 skipped **Nextest:** 505 tests, 505 passed, 0 failed, 0 skipped **Doctests:** 11 tests, 1 passed, 0 failed, 10 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital | 1 | 1 | 0 | 0 | - | 0.70s | | orbital-cli | 3 | 3 | 0 | 0 | - | 0.05s | | orbital_2d | 29 | 29 | 0 | 0 | 0/1 | 0.17s | | orbital_app | 19 | 19 | 0 | 0 | 0/1 | 0.11s | | orbital_billboard | 9 | 9 | 0 | 0 | - | 0.22s | | orbital_camera | 8 | 8 | 0 | 0 | - | 0.05s | | orbital_core | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_debug_render | 2 | 2 | 0 | 0 | 0/1 | 0.01s | | orbital_debug_ui | 50 | 50 | 0 | 0 | 0/1 | 0.29s | | orbital_ecs | 114 | 114 | 0 | 0 | 0/2 | 0.65s | | orbital_ecs_bridge | 45 | 45 | 0 | 0 | - | 0.27s | | orbital_file_manager | 5 | 5 | 0 | 0 | - | 0.03s | | orbital_iced | 26 | 26 | 0 | 0 | - | 0.15s | | orbital_importer_gltf | 16 | 16 | 0 | 0 | - | 0.15s | | orbital_input | 11 | 11 | 0 | 0 | - | 0.05s | | orbital_light | 6 | 6 | 0 | 0 | - | 0.03s | | orbital_macros | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_material_shader | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_math | 4 | 4 | 0 | 0 | - | 0.02s | | orbital_mesh | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_procgeo | 3 | 3 | 0 | 0 | - | 0.01s | | orbital_render_graph | 6 | 6 | 0 | 0 | - | 0.03s | | orbital_renderer | 21 | 21 | 0 | 0 | - | 0.19s | | orbital_resources | 29 | 29 | 0 | 0 | - | 0.20s | | orbital_shader_core | 0 | 0 | 0 | 0 | 1/1 | 0.00s | | orbital_shader_pbr | 4 | 4 | 0 | 0 | - | 0.02s | | orbital_shader_preprocessor | 12 | 12 | 0 | 0 | - | 0.05s | | orbital_shadow | 3 | 3 | 0 | 0 | - | 0.01s | | orbital_text | 14 | 14 | 0 | 0 | 0/1 | 0.30s | | orbital_texture | 11 | 11 | 0 | 0 | - | 0.05s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.01s | | orbital_ui | 32 | 32 | 0 | 0 | 0/1 | 0.16s | | orbital_world_environment | 13 | 13 | 0 | 0 | - | 0.08s | | template_all_in_one | 2 | 2 | 0 | 0 | - | 0.01s | ```mermaid pie showData title Nextest outcomes "Passed" : 505 ``` ```mermaid pie showData title Doctest outcomes "Passed" : 1 "Skipped" : 10 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital", "orbital_ecs", "orbital_text", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_billboard", "orbital_resources", "orbital_renderer"] y-axis "Seconds" 0 --> 1 bar [0.70, 0.65, 0.30, 0.29, 0.27, 0.22, 0.20, 0.19] ```
SakulFlee deleted branch fix/iced-init-fallback 2026-11-06 21:17:04 +00:00
Sign in to join this conversation.
No description provided.