fix(android): request shader f16 for iced and gate the touch toggle #1065
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!1065
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/android-shader-f16"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Android log finally exposed the real iced failure:
iced uses
unpack2x16float, so the shared wgpu device must enableFeatures::SHADER_F16when the adapter supports it. The embedded iced renderer does not request the device itself; the Orbital context previously only requested line/timestamp features.SHADER_F16from the adapter when available.SHADER_F16; devices like the llvmpipe emulator hide it instead of trying to initialize iced.with_mobile_toggle(false)available for apps that want to hide it explicitly.On a phone whose Mali driver exposes shader f16, iced should initialize now. On devices without it, the app keeps running without the button. #1063 remains as the fallback if a supported device still fails pipeline creation.
Smart test results
Result: PASS
Scope: orbital_app, orbital_debug_ui
Reason: directly changed crates
Elapsed: 2m 55s
Workflow run
Overall: 72 tests, 70 passed, 0 failed, 2 skipped
Nextest: 70 tests, 70 passed, 0 failed, 0 skipped
Doctests: 2 tests, 0 passed, 0 failed, 2 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.