fix(android): request shader f16 for iced and gate the touch toggle #1065

Merged
SakulFlee merged 1 commit from fix/android-shader-f16 into main 2026-11-06 22:36:07 +00:00
Owner

The Android log finally exposed the real iced failure:

iced_wgpu.quad.solid.shader: Function unpack_u32 is invalid
Shader requires capability SHADER_FLOAT16_IN_FLOAT32

iced uses unpack2x16float, so the shared wgpu device must enable Features::SHADER_F16 when the adapter supports it. The embedded iced renderer does not request the device itself; the Orbital context previously only requested line/timestamp features.

  • Request SHADER_F16 from the adapter when available.
  • Restore the mobile debug toggle on Android, but only make it visible when the device actually has SHADER_F16; devices like the llvmpipe emulator hide it instead of trying to initialize iced.
  • Keep with_mobile_toggle(false) available for apps that want to hide it explicitly.

On a phone whose Mali driver exposes shader f16, iced should initialize now. On devices without it, the app keeps running without the button. #1063 remains as the fallback if a supported device still fails pipeline creation.

The Android log finally exposed the real iced failure: ```text iced_wgpu.quad.solid.shader: Function unpack_u32 is invalid Shader requires capability SHADER_FLOAT16_IN_FLOAT32 ``` iced uses `unpack2x16float`, so the shared wgpu device must enable `Features::SHADER_F16` when the adapter supports it. The embedded iced renderer does not request the device itself; the Orbital context previously only requested line/timestamp features. - Request `SHADER_F16` from the adapter when available. - Restore the mobile debug toggle on Android, but only make it visible when the device actually has `SHADER_F16`; devices like the llvmpipe emulator hide it instead of trying to initialize iced. - Keep `with_mobile_toggle(false)` available for apps that want to hide it explicitly. On a phone whose Mali driver exposes shader f16, iced should initialize now. On devices without it, the app keeps running without the button. #1063 remains as the fallback if a supported device still fails pipeline creation.
fix(android): request shader f16 for iced and gate the touch toggle
All checks were successful
Lint / lint (pull_request) Successful in 1m22s
PR / test (pull_request) Successful in 3m19s
00aded1f7a

Smart test results

Result: PASS

Scope: orbital_app, orbital_debug_ui

Reason: directly changed crates

Elapsed: 2m 55s

Workflow run

Overall: 72 tests, 70 passed, 0 failed, 2 skipped

Nextest: 70 tests, 70 passed, 0 failed, 0 skipped
Doctests: 2 tests, 0 passed, 0 failed, 2 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 19 19 0 0 0/1 0.08s
orbital_debug_ui 51 51 0 0 0/1 0.24s
pie showData
    title Nextest outcomes
    "Passed" : 70
pie showData
    title Doctest outcomes
    "Skipped" : 2
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_debug_ui", "orbital_app"]
    y-axis "Seconds" 0 --> 1
    bar [0.24, 0.08]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_debug_ui **Reason:** directly changed crates **Elapsed:** 2m 55s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/1187) **Overall:** 72 tests, 70 passed, 0 failed, 2 skipped **Nextest:** 70 tests, 70 passed, 0 failed, 0 skipped **Doctests:** 2 tests, 0 passed, 0 failed, 2 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 19 | 19 | 0 | 0 | 0/1 | 0.08s | | orbital_debug_ui | 51 | 51 | 0 | 0 | 0/1 | 0.24s | ```mermaid pie showData title Nextest outcomes "Passed" : 70 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 2 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_debug_ui", "orbital_app"] y-axis "Seconds" 0 --> 1 bar [0.24, 0.08] ```
SakulFlee deleted branch fix/android-shader-f16 2026-11-06 22:36:07 +00:00
Sign in to join this conversation.
No description provided.