fix: assign present_mode to surface config instead of no-op read #676

Merged

SakulFlee merged 1 commit from fix/vsync-present-mode into main

2026-07-05 04:00:48 +02:00

Hermes commented

2026-07-05 03:59:07 +02:00

Collaborator

Fixes #668

The make_surface_configuration method computed present_mode from the vsync parameter but the value was never assigned — it was a no-op expression statement. This meant VSync settings had no effect; the surface always used whatever get_default_config returned.

Fix: default_config.present_mode = present_mode;

Fixes #668 The `make_surface_configuration` method computed `present_mode` from the `vsync` parameter but the value was never assigned — it was a no-op expression statement. This meant VSync settings had no effect; the surface always used whatever `get_default_config` returned. **Fix:** `default_config.present_mode = present_mode;`

SakulFlee was assigned by Hermes

2026-07-05 03:59:07 +02:00

Hermes added 1 commit

2026-07-05 03:59:07 +02:00

fix: assign present_mode to surface config instead of no-op read

ci/woodpecker/pr/test Pipeline was canceled

Details

ci/woodpecker/push/test Pipeline was canceled

Details

7dfc21b85b

The make_surface_configuration computed present_mode from the vsync
parameter but never assigned it to the SurfaceConfiguration struct,
leaving the line as a no-op expression statement. VSync was silently
ignored and the default present mode from get_default_config was used.

Fixes #668

Hermes referenced this pull request

2026-07-05 03:59:12 +02:00

VSync setting silently ignored in make_surface_configuration #668

SakulFlee approved these changes

2026-07-05 04:00:41 +02:00

SakulFlee merged commit 275c7f121d into main

2026-07-05 04:00:48 +02:00

SakulFlee referenced this pull request from a commit

2026-07-05 04:00:49 +02:00

Merge pull request 'fix: assign present_mode to surface config instead of no-op read' (#676) from fix/vsync-present-mode into main