perf(renderer): resolve timestamps in the scene submission #934

Merged
SakulFlee merged 2 commits from perf/renderer-single-submit into main 2026-10-26 01:29:01 +00:00
Collaborator

Summary

Stacked on #933 (phase 1a). Folds the timestamp query resolve and staging copies into the scene command encoder, so the main scene frame uses one queue.submit instead of a render submit plus a separate timestamp submit.

  • Record resolve_query_set and copy_buffer_to_buffer after the final scene timestamp.
  • Submit once, then read the previous frame's staging buffer as before.
  • Remove the now-unused prev_resolve_sub field.

Overlay renderers still submit separately; that is the next phase-1 change.

Verification

  • cargo fmt --all -- --check
  • cargo clippy -p orbital_renderer -- -D warnings
  • cargo test -p orbital_renderer --no-fail-fast

Refs #781.

## Summary Stacked on #933 (phase 1a). Folds the timestamp query resolve and staging copies into the scene command encoder, so the main scene frame uses one `queue.submit` instead of a render submit plus a separate timestamp submit. - Record `resolve_query_set` and `copy_buffer_to_buffer` after the final scene timestamp. - Submit once, then read the previous frame's staging buffer as before. - Remove the now-unused `prev_resolve_sub` field. Overlay renderers still submit separately; that is the next phase-1 change. ## Verification - `cargo fmt --all -- --check` - `cargo clippy -p orbital_renderer -- -D warnings` - `cargo test -p orbital_renderer --no-fail-fast` Refs #781.
perf(renderer): resolve timestamps in the scene submission
All checks were successful
Lint / lint (pull_request) Successful in 1m54s
PR / test (pull_request) Successful in 2m36s
e84f45f873
Record query resolve and staging copies in the same command encoder as the shadow, sky and model passes. The scene frame now submits once instead of once for rendering plus once for timestamp resolution.

Smart test results

Result: PASS

Scope: orbital_renderer

Reason: directly changed crates

Elapsed: 53.6s

Workflow run

Overall: 2 tests, 2 passed, 0 failed, 0 skipped

Nextest: 2 tests, 2 passed, 0 failed, 0 skipped
Doctests: no tests reported

Crate Nextest Passed Failed Skipped Doctests Time
orbital_renderer 2 2 0 0 - 0.02s
pie showData
    title Nextest outcomes
    "Passed" : 2
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_renderer **Reason:** directly changed crates **Elapsed:** 53.6s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/626) **Overall:** 2 tests, 2 passed, 0 failed, 0 skipped **Nextest:** 2 tests, 2 passed, 0 failed, 0 skipped **Doctests:** no tests reported | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_renderer | 2 | 2 | 0 | 0 | - | 0.02s | ```mermaid pie showData title Nextest outcomes "Passed" : 2 ```
SakulFlee changed target branch from refactor/renderer-phase-1 to main 2026-10-26 01:22:09 +00:00
Merge branch 'main' into perf/renderer-single-submit
All checks were successful
Lint / lint (pull_request) Successful in 1m13s
PR / test (pull_request) Successful in 1m37s
8e20286496
SakulFlee deleted branch perf/renderer-single-submit 2026-10-26 01:29:02 +00:00
Sign in to join this conversation.
No description provided.