perf(renderer): cache the world bind group #936
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!936
Loading…
Reference in a new issue
No description provided.
Delete branch "perf/renderer-bind-group-cache"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Stacked on #933 (phase 1a). Caches the world bind group instead of recreating it every frame.
Arcs alive in the cache, so allocator address reuse cannot produce a false hit.ShadowRenderernow exposes a generation counter that is bumped when its texture arrays grow.Buffer and texture contents can still change every frame; only replacing a resource invalidates the binding.
Verification
cargo fmt --all -- --checkcargo clippy -p orbital_renderer -p orbital_shadow -p orbital_app -- -D warningscargo test -p orbital_renderer -p orbital_shadow -p orbital_app --no-fail-fastRefs #781.
Smart test results
Result: PASS
Scope: orbital_renderer, orbital_shadow
Reason: directly changed crates
Elapsed: 37.3s
Workflow run
Overall: 5 tests, 5 passed, 0 failed, 0 skipped
Nextest: 5 tests, 5 passed, 0 failed, 0 skipped
Doctests: no tests reported