fix(debug-ui): unlock dropdowns and clarify volumetrics #972

Merged
SakulFlee merged 1 commit from fix/rendering-controls-followup into main 2026-10-29 17:09:38 +00:00
Owner

Summary

Follow-up fixes for the new Rendering debug panel.

Dropdown fix

FloatingPanel::overlay returned an empty list, so overlay widgets such as pick_list could never open inside a debug panel. The panel now forwards its content child's overlay, which fixes the Perspective/Orthographic dropdown.

Rendering panel

  • SMAA quality is now only shown while SMAA is selected.
  • Volumetrics controls now explain what the values mean and expose the missing knobs:
    • base density
    • base height (world-space Y)
    • height density
    • height falloff
    • scattering
    • extinction
    • anisotropy
    • max distance
  • height_base and height_falloff documentation now explicitly describes the world-Y height layer.
  • Added short help text for height fog and froxels.

AA diagnostics

Changing AA mode or SMAA quality now emits an info-level log when the renderer actually applies the change, so the Console panel can confirm whether the runtime is applying panel edits.

Notes

This does not yet change the AA implementation or volumetrics quality behavior. Those need the visual verification planned next.

Validation

  • cargo test -p orbital_debug_ui -p orbital_iced --all-targets passes.
  • cargo check --workspace with the workspace clippy driver and -D warnings passes.
  • rustfmt --check passes for all Crates/ and Examples/ Rust sources.

Related: #970, #969, #971.

## Summary Follow-up fixes for the new Rendering debug panel. ### Dropdown fix `FloatingPanel::overlay` returned an empty list, so overlay widgets such as `pick_list` could never open inside a debug panel. The panel now forwards its content child's overlay, which fixes the Perspective/Orthographic dropdown. ### Rendering panel - SMAA quality is now only shown while SMAA is selected. - Volumetrics controls now explain what the values mean and expose the missing knobs: - base density - base height (world-space Y) - height density - height falloff - scattering - extinction - anisotropy - max distance - `height_base` and `height_falloff` documentation now explicitly describes the world-Y height layer. - Added short help text for height fog and froxels. ### AA diagnostics Changing AA mode or SMAA quality now emits an info-level log when the renderer actually applies the change, so the Console panel can confirm whether the runtime is applying panel edits. ## Notes This does not yet change the AA implementation or volumetrics quality behavior. Those need the visual verification planned next. ## Validation - `cargo test -p orbital_debug_ui -p orbital_iced --all-targets` passes. - `cargo check --workspace` with the workspace clippy driver and `-D warnings` passes. - `rustfmt --check` passes for all `Crates/` and `Examples/` Rust sources. Related: #970, #969, #971.
fix(debug-ui): unlock dropdowns and clarify volumetrics
All checks were successful
Lint / lint (pull_request) Successful in 1m38s
PR / test (pull_request) Successful in 4m11s
6346bf222b

Smart test results

Result: PASS

Scope: orbital_app, orbital_debug_ui, orbital_ecs_bridge, orbital_iced

Reason: directly changed crates

Elapsed: 3m 28s

Workflow run

Overall: 127 tests, 125 passed, 0 failed, 2 skipped

Nextest: 125 tests, 125 passed, 0 failed, 0 skipped
Doctests: 2 tests, 0 passed, 0 failed, 2 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 10 10 0 0 0/1 0.05s
orbital_debug_ui 48 48 0 0 0/1 0.23s
orbital_ecs_bridge 42 42 0 0 - 0.22s
orbital_iced 25 25 0 0 - 0.11s
pie showData
    title Nextest outcomes
    "Passed" : 125
pie showData
    title Doctest outcomes
    "Skipped" : 2
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_debug_ui", "orbital_ecs_bridge", "orbital_iced", "orbital_app"]
    y-axis "Seconds" 0 --> 1
    bar [0.23, 0.22, 0.11, 0.05]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_debug_ui, orbital_ecs_bridge, orbital_iced **Reason:** directly changed crates **Elapsed:** 3m 28s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/842) **Overall:** 127 tests, 125 passed, 0 failed, 2 skipped **Nextest:** 125 tests, 125 passed, 0 failed, 0 skipped **Doctests:** 2 tests, 0 passed, 0 failed, 2 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 10 | 10 | 0 | 0 | 0/1 | 0.05s | | orbital_debug_ui | 48 | 48 | 0 | 0 | 0/1 | 0.23s | | orbital_ecs_bridge | 42 | 42 | 0 | 0 | - | 0.22s | | orbital_iced | 25 | 25 | 0 | 0 | - | 0.11s | ```mermaid pie showData title Nextest outcomes "Passed" : 125 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 2 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_debug_ui", "orbital_ecs_bridge", "orbital_iced", "orbital_app"] y-axis "Seconds" 0 --> 1 bar [0.23, 0.22, 0.11, 0.05] ```
Sign in to join this conversation.
No description provided.