Track: anti-aliasing — TAA/TSAA, SMAA variants, and runtime controls #969

Open
opened 2026-10-29 02:59:34 +00:00 by SakulFlee · 2 comments
Owner

Summary

Track the remaining anti-aliasing work as one workstream: temporal anti-aliasing (TAA/TSAA), the remaining SMAA variants, and the quality/runtime controls around them.

The renderer currently supports:

  • Off
  • FXAA
  • SMAA 1x with Low, Medium, High, and Ultra presets

This issue is the umbrella for deciding which temporal and spatial variants are worth implementing, and in what order.

Goals

  • Add a temporal anti-aliasing path that can be enabled potentially as TAA/TSAA.
  • Keep the existing spatial paths (FXAA and SMAA 1x) as low-cost options.
  • Make the selected AA mode and quality runtime-switchable.
  • Define quality/performance trade-offs and document them.
  • Keep 2D, UI, and text rendering sharp; AA applies to the 3D scene post chain only.

TAA / TSAA

Temporal AA needs more than a post-process shader toggle:

  • camera jitter per frame
  • previous-frame color and depth history
  • velocity/reprojection for moving geometry and camera motion
  • disocclusion rejection and anti-ghosting
  • history reset on camera cuts, resize, or major scene changes
  • stable output under motion, transparency, and thin geometry

TSAA can be treated as the temporal supersampling variant of the same foundation. It should be evaluated for quality and cost before committing to a specific sample count.

Acceptance criteria:

  • TAA can be enabled and disabled at runtime.
  • History is correctly reset on resize and camera discontinuities.
  • Moving cameras and geometry do not produce obvious ghosting or smearing.
  • Transparent and alpha-masked surfaces are handled explicitly.
  • A noop/validation test covers the new pipelines and layouts.
  • Documented performance and quality comparison against FXAA and SMAA.

SMAA

SMAA 1x is spatial and is already implemented. Its quality presets are now exposed (Low/Medium/High/Ultra); see #966.

Still to evaluate:

  • SMAA T2x: temporal variant. Requires velocity/reprojection and previous-frame history, sharing much of the TAA foundation.
  • SMAA S2x / 4x: spatial subsampling/MSAA variants. Requires subsample-index or MSAA plumbing rather than just more search steps.
  • Color/depth edge detection and predication are available in the upstream WGSL port but are not exposed as options yet.
  • Decide whether subpixel/quality presets should be configurable independently of the AA mode.

Acceptance criteria:

  • Document which SMAA variants are implemented and which are intentionally omitted.
  • If T2x is added, it shares the temporal history/velocity infrastructure with TAA rather than duplicating it.
  • Variant selection is available to the app and, where practical, the rendering debug panel.
  • Tests validate every exposed pipeline configuration on the noop backend.

Runtime controls

  • AA mode: Off / FXAA / SMAA (and later TAA/TSAA).
  • SMAA quality and any future variant-specific settings.
  • Preserve current behavior: FXAA remains the default; SMAA remains opt-in.
  • #958 — LUT-based SMAA
  • #939 — FXAA
  • #585 — earlier anti-aliasing issue
  • #781 — renderer overhaul umbrella

Out of scope

This issue does not require implementing every SMAA variant. The outcome may be TAA plus SMAA 1x, with T2x/S2x/4x documented as not pursued if the cost/benefit is poor.

## Summary Track the remaining anti-aliasing work as one workstream: temporal anti-aliasing (TAA/TSAA), the remaining SMAA variants, and the quality/runtime controls around them. The renderer currently supports: - `Off` - FXAA - SMAA 1x with `Low`, `Medium`, `High`, and `Ultra` presets This issue is the umbrella for deciding which temporal and spatial variants are worth implementing, and in what order. ## Goals - Add a temporal anti-aliasing path that can be enabled potentially as TAA/TSAA. - Keep the existing spatial paths (FXAA and SMAA 1x) as low-cost options. - Make the selected AA mode and quality runtime-switchable. - Define quality/performance trade-offs and document them. - Keep 2D, UI, and text rendering sharp; AA applies to the 3D scene post chain only. ## TAA / TSAA Temporal AA needs more than a post-process shader toggle: - camera jitter per frame - previous-frame color and depth history - velocity/reprojection for moving geometry and camera motion - disocclusion rejection and anti-ghosting - history reset on camera cuts, resize, or major scene changes - stable output under motion, transparency, and thin geometry TSAA can be treated as the temporal supersampling variant of the same foundation. It should be evaluated for quality and cost before committing to a specific sample count. Acceptance criteria: - TAA can be enabled and disabled at runtime. - History is correctly reset on resize and camera discontinuities. - Moving cameras and geometry do not produce obvious ghosting or smearing. - Transparent and alpha-masked surfaces are handled explicitly. - A noop/validation test covers the new pipelines and layouts. - Documented performance and quality comparison against FXAA and SMAA. ## SMAA SMAA 1x is spatial and is already implemented. Its quality presets are now exposed (`Low`/`Medium`/`High`/`Ultra`); see #966. Still to evaluate: - **SMAA T2x**: temporal variant. Requires velocity/reprojection and previous-frame history, sharing much of the TAA foundation. - **SMAA S2x / 4x**: spatial subsampling/MSAA variants. Requires subsample-index or MSAA plumbing rather than just more search steps. - Color/depth edge detection and predication are available in the upstream WGSL port but are not exposed as options yet. - Decide whether subpixel/quality presets should be configurable independently of the AA mode. Acceptance criteria: - Document which SMAA variants are implemented and which are intentionally omitted. - If T2x is added, it shares the temporal history/velocity infrastructure with TAA rather than duplicating it. - Variant selection is available to the app and, where practical, the rendering debug panel. - Tests validate every exposed pipeline configuration on the noop backend. ## Runtime controls - AA mode: Off / FXAA / SMAA (and later TAA/TSAA). - SMAA quality and any future variant-specific settings. - Preserve current behavior: FXAA remains the default; SMAA remains opt-in. ## Related - #958 — LUT-based SMAA - #939 — FXAA - #585 — earlier anti-aliasing issue - #781 — renderer overhaul umbrella ## Out of scope This issue does not require implementing every SMAA variant. The outcome may be TAA plus SMAA 1x, with T2x/S2x/4x documented as not pursued if the cost/benefit is poor.
Author
Owner

Status from rendering-panel testing:

  • The Perspective/Orthographic dropdown now works after the FloatingPanel::overlay forwarding fix in #972.
  • AA mode and SMAA quality changes are applied by ModuleRuntime and produce the expected info-level renderer logs.
  • No visible AA difference has been observed yet, including on hard shadow edges.

Next step is a high-contrast AA test view (thin diagonal geometry, tight checker/grid, fixed camera) and a pass/target verification. The log proves the renderer setting changes; it does not yet prove the FXAA/SMAA pass is reaching the presented surface. Shadow-map filtering/PCF is a separate concern from post-process AA.

Status from rendering-panel testing: - The Perspective/Orthographic dropdown now works after the `FloatingPanel::overlay` forwarding fix in #972. - AA mode and SMAA quality changes are applied by `ModuleRuntime` and produce the expected info-level renderer logs. - No visible AA difference has been observed yet, including on hard shadow edges. Next step is a high-contrast AA test view (thin diagonal geometry, tight checker/grid, fixed camera) and a pass/target verification. The log proves the renderer setting changes; it does not yet prove the FXAA/SMAA pass is reaching the presented surface. Shadow-map filtering/PCF is a separate concern from post-process AA.
Author
Owner

Add the view-aligned froxel flicker to the TAA scope.

Temporal volumetrics

The volumetric grid is view-aligned and currently has no temporal history. As the camera moves, a short spot cone moves across froxel cells, producing the full/half/none popping still visible at longer ranges. The linear-depth and adaptive-slice fixes reduced the spatial spacing, but did not remove the temporal component.

The TAA/TAA foundation should cover:

  • a per-frame sub-froxel jitter offset
  • previous-frame froxel history
  • reprojection from world/view space into the previous frame
  • rejection/blending rules for disocclusion and camera cuts
  • resize and max-distance changes invalidating history
  • interaction with the existing SMAA/FXAA post chain

This is shared work with the temporal history/reprojection needed by TAA proper.

SMAA and FXAA

SMAA 1x and FXAA are spatial post-process passes. They run on the final LDR scene color and cannot prevent the volumetric cone from popping between frames; they can only smooth the resulting screen-space edges.

  • FXAA: no temporal component.
  • SMAA 1x: no temporal component.
  • SMAA T2x: temporal, but built around velocity/reprojection for geometric edges; it would still need the same volumetric history/reprojection work.
  • SMAA S2x/4x: subsampling/MSAA, not a fix for camera-motion froxel aliasing.

So temporal froxel accumulation belongs in the TAA workstream, not the spatial SMAA presets.

Add the view-aligned froxel flicker to the TAA scope. ## Temporal volumetrics The volumetric grid is view-aligned and currently has no temporal history. As the camera moves, a short spot cone moves across froxel cells, producing the full/half/none popping still visible at longer ranges. The linear-depth and adaptive-slice fixes reduced the spatial spacing, but did not remove the temporal component. The TAA/TAA foundation should cover: - a per-frame sub-froxel jitter offset - previous-frame froxel history - reprojection from world/view space into the previous frame - rejection/blending rules for disocclusion and camera cuts - resize and max-distance changes invalidating history - interaction with the existing SMAA/FXAA post chain This is shared work with the temporal history/reprojection needed by TAA proper. ## SMAA and FXAA SMAA 1x and FXAA are spatial post-process passes. They run on the final LDR scene color and cannot prevent the volumetric cone from popping between frames; they can only smooth the resulting screen-space edges. - FXAA: no temporal component. - SMAA 1x: no temporal component. - SMAA T2x: temporal, but built around velocity/reprojection for geometric edges; it would still need the same volumetric history/reprojection work. - SMAA S2x/4x: subsampling/MSAA, not a fix for camera-motion froxel aliasing. So temporal froxel accumulation belongs in the TAA workstream, not the spatial SMAA presets.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SakulFlee/Orbital#969
No description provided.