fix(renderer): make positional light glare opt-in #1003

Merged
SakulFlee merged 1 commit from fix/light-glare-opt-in into main 2026-10-31 17:48:36 +00:00
Owner

Summary

  • The billboard-light implementation is already removed; the remaining round glows are the newer screen-space glare generated from positional lights.
  • Make that positional-light glare opt-in and default it off, including in All-in-One.
  • Add a Light glare checkbox to the Rendering panel.
  • Keep scene bloom independent from light glare.

Notes

  • All-in-One now has no per-light marker or glare geometry by default.
  • Enable Light glare in the Rendering panel to get a depth-tested halo around visible point/spot lights.
  • If hard orbs are still visible after a clean rebuild, verify F3 debug markers are off and send a screenshot.
## Summary - The billboard-light implementation is already removed; the remaining round glows are the newer screen-space glare generated from positional lights. - Make that positional-light glare opt-in and default it off, including in All-in-One. - Add a **Light glare** checkbox to the Rendering panel. - Keep scene bloom independent from light glare. ## Notes - All-in-One now has no per-light marker or glare geometry by default. - Enable **Light glare** in the Rendering panel to get a depth-tested halo around visible point/spot lights. - If hard orbs are still visible after a clean rebuild, verify F3 debug markers are off and send a screenshot.
fix(renderer): make positional light glare opt-in
All checks were successful
Lint / lint (pull_request) Successful in 1m31s
Templates / templates (pull_request) Successful in 4m53s
PR / test (pull_request) Successful in 6m31s
b048e5b75c

Smart test results

Result: PASS

Scope: orbital_app, orbital_debug_ui, orbital_renderer

Reason: directly changed crates

Elapsed: 5m 34s

Workflow run

Overall: 80 tests, 78 passed, 0 failed, 2 skipped

Nextest: 78 tests, 78 passed, 0 failed, 0 skipped
Doctests: 2 tests, 0 passed, 0 failed, 2 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 10 10 0 0 0/1 0.10s
orbital_debug_ui 48 48 0 0 0/1 0.27s
orbital_renderer 20 20 0 0 - 0.20s
pie showData
    title Nextest outcomes
    "Passed" : 78
pie showData
    title Doctest outcomes
    "Skipped" : 2
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_debug_ui", "orbital_renderer", "orbital_app"]
    y-axis "Seconds" 0 --> 1
    bar [0.27, 0.20, 0.10]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_debug_ui, orbital_renderer **Reason:** directly changed crates **Elapsed:** 5m 34s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/939) **Overall:** 80 tests, 78 passed, 0 failed, 2 skipped **Nextest:** 78 tests, 78 passed, 0 failed, 0 skipped **Doctests:** 2 tests, 0 passed, 0 failed, 2 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 10 | 10 | 0 | 0 | 0/1 | 0.10s | | orbital_debug_ui | 48 | 48 | 0 | 0 | 0/1 | 0.27s | | orbital_renderer | 20 | 20 | 0 | 0 | - | 0.20s | ```mermaid pie showData title Nextest outcomes "Passed" : 78 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 2 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_debug_ui", "orbital_renderer", "orbital_app"] y-axis "Seconds" 0 --> 1 bar [0.27, 0.20, 0.10] ```
SakulFlee referenced this pull request from a commit 2026-10-31 17:48:37 +00:00
Sign in to join this conversation.
No description provided.