fix(importer): expand glTF triangle strips and fans #1043
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!1043
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/gltf-primitive-modes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Expands
TRIANGLE_STRIPandTRIANGLE_FANglTF primitives to a triangle list before normal generation and winding conversion. Unsupported point/line topologies are now warned about and skipped instead of imported as malformed triangles.Adds end-to-end strip and fan import tests that pin the expanded and winding-flipped index order.
Fixes #841.
Smart test results
Result: PASS
Scope: orbital_importer_gltf
Reason: directly changed crates
Elapsed: 3m 16s
Workflow run
Overall: 16 tests, 16 passed, 0 failed, 0 skipped
Nextest: 16 tests, 16 passed, 0 failed, 0 skipped
Doctests: no tests reported