fix(iced): wait for the real surface format before building pipelines #1062
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!1062
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/android-iced-format"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Android log shows
iced_wgpu.quad.solid.pipelinebeing rejected as an invalid resource. The new mobile debug toggle is visible on the very first update, so iced can initialize beforeSurfaceFormatResourceexists and previously fell back toBgra8UnormSrgb. On Android that can produce pipelines for a format the surface cannot use.This makes
IcedLayerRendererrequire the configured surface format before creating any iced renderer or building a UI. It also tracks format changes across surface recreation and drops/recreates the iced renderer when the format changes, instead of reusing pipelines built for the old target.Adds a unit test for the missing-format and format-change cases.
Refs #1061. Needs Android confirmation; if it still fails, please attach the full
adb logcataroundSelected format/ pipeline creation.Smart test results
Result: PASS
Scope: orbital_iced
Reason: directly changed crates
Elapsed: 6m 27s
Workflow run
Overall: 26 tests, 26 passed, 0 failed, 0 skipped
Nextest: 26 tests, 26 passed, 0 failed, 0 skipped
Doctests: no tests reported