fix: clamp camera pitch before vertical #927
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!927
Loading…
Reference in a new issue
No description provided.
Delete branch "sakulflee/fix-912-camera-pitch-clamp"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Clamps camera pitch on mouse, gamepad, and touch input so the view cannot cross straight up or down. Previously only touch look clamped pitch; mouse and gamepad could flip the up vector and make the camera appear to revolve around itself.
Rotation::pitch()andRotation::rotate_pitch_clamped().Fixes #912
Smart test results
Result: FAIL
Failure: nextest and doctest command failed
Scope: orbital_app, orbital_ecs_bridge
Reason: directly changed crates
Elapsed: 2m 14s
Workflow run
Overall: 0 tests, 0 passed, 0 failed, 0 skipped
Nextest: build failed (no test report)
Doctests: command failed (no test report)
Nextest output tail
Doctest output tail