refactor(app): unify overlay rendering on LayerRenderer #964
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!964
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/overlay-layers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Removes the parallel legacy overlay API and unifies all overlays on
LayerRenderer.OverlaySubmission::{MainEncoder, Owned}toLayerRenderer.Owneduntil its fork exposes an encoder.LayerRendererwithWorld2D,UI, andDebuglayers.RenderOverlaytrait,RenderOverlayResource::overlays,RenderOverlayResource::add, and the legacy parameter fromModule::register_overlays.STAGE_OVERLAY_MAINand documents the submission-order caveat.Depends on #963; the PR targets
perf/renderer-overlay-submitand should be retargeted tomainafter #963 merges.Validation
cargo test --workspace --no-fail-fastpasses.cargo check --workspacewith the workspace clippy driver and-D warningspasses.Crates/andExamples/.Smart test results
Result: PASS
Scope: orbital_app, orbital_debug_render, orbital_debug_ui, orbital_ecs_bridge, orbital_iced, orbital_touch_ui
Reason: directly changed crates
Elapsed: 5m 56s
Workflow run
Overall: 127 tests, 123 passed, 0 failed, 4 skipped
Nextest: 123 tests, 123 passed, 0 failed, 0 skipped
Doctests: 4 tests, 0 passed, 0 failed, 4 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.