feat(renderer): expose SMAA quality presets #966

Merged
SakulFlee merged 1 commit from feat/smaa-quality-presets into main 2026-10-29 02:54:33 +00:00
Owner

Summary

Adds the reference SMAA quality presets to the current SMAA 1x implementation.

  • New SmaaQuality::{Low, Medium, High, Ultra} presets.
  • Presets set edge threshold, search steps, diagonal search steps, corner rounding, and diagonal/corner disable flags through pipeline constants.
  • AppSettings::smaa_quality exposes the preset at app level; Renderer::set_smaa_quality is available for runtime control.
  • Default remains High, preserving the previous behavior.
  • The SMAA target is recreated lazily when quality changes.
  • The noop-backend test now validates all four presets.

SMAA T2x/S2x/4x are not included: they need temporal history and velocity reprojection or subsample/MSAA plumbing, which is a separate feature.

Validation

  • cargo test --workspace --no-fail-fast passes, including all SMAA presets through the noop backend.
  • cargo check --workspace with the workspace clippy driver and -D warnings passes.
  • Rust formatting checks pass across Crates/ and Examples/.
  • Real GPU visual comparison of the presets is still required.
## Summary Adds the reference SMAA quality presets to the current SMAA 1x implementation. - New `SmaaQuality::{Low, Medium, High, Ultra}` presets. - Presets set edge threshold, search steps, diagonal search steps, corner rounding, and diagonal/corner disable flags through pipeline constants. - `AppSettings::smaa_quality` exposes the preset at app level; `Renderer::set_smaa_quality` is available for runtime control. - Default remains `High`, preserving the previous behavior. - The SMAA target is recreated lazily when quality changes. - The noop-backend test now validates all four presets. SMAA T2x/S2x/4x are not included: they need temporal history and velocity reprojection or subsample/MSAA plumbing, which is a separate feature. ## Validation - `cargo test --workspace --no-fail-fast` passes, including all SMAA presets through the noop backend. - `cargo check --workspace` with the workspace clippy driver and `-D warnings` passes. - Rust formatting checks pass across `Crates/` and `Examples/`. - Real GPU visual comparison of the presets is still required.
feat(renderer): expose SMAA quality presets
All checks were successful
Lint / lint (pull_request) Successful in 1m27s
PR / test (pull_request) Successful in 3m15s
30c7486890

Smart test results

Result: PASS

Scope: orbital_app, orbital_renderer

Reason: directly changed crates

Elapsed: 2m 50s

Workflow run

Overall: 28 tests, 27 passed, 0 failed, 1 skipped

Nextest: 27 tests, 27 passed, 0 failed, 0 skipped
Doctests: 1 tests, 0 passed, 0 failed, 1 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 10 10 0 0 0/1 0.05s
orbital_renderer 17 17 0 0 - 0.14s
pie showData
    title Nextest outcomes
    "Passed" : 27
pie showData
    title Doctest outcomes
    "Skipped" : 1
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_renderer", "orbital_app"]
    y-axis "Seconds" 0 --> 1
    bar [0.14, 0.05]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_renderer **Reason:** directly changed crates **Elapsed:** 2m 50s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/833) **Overall:** 28 tests, 27 passed, 0 failed, 1 skipped **Nextest:** 27 tests, 27 passed, 0 failed, 0 skipped **Doctests:** 1 tests, 0 passed, 0 failed, 1 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 10 | 10 | 0 | 0 | 0/1 | 0.05s | | orbital_renderer | 17 | 17 | 0 | 0 | - | 0.14s | ```mermaid pie showData title Nextest outcomes "Passed" : 27 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 1 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_renderer", "orbital_app"] y-axis "Seconds" 0 --> 1 bar [0.14, 0.05] ```
SakulFlee deleted branch feat/smaa-quality-presets 2026-10-29 02:54:34 +00:00
Sign in to join this conversation.
No description provided.