feat(renderer): expose SMAA quality presets #966
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!966
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/smaa-quality-presets"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Adds the reference SMAA quality presets to the current SMAA 1x implementation.
SmaaQuality::{Low, Medium, High, Ultra}presets.AppSettings::smaa_qualityexposes the preset at app level;Renderer::set_smaa_qualityis available for runtime control.High, preserving the previous behavior.SMAA T2x/S2x/4x are not included: they need temporal history and velocity reprojection or subsample/MSAA plumbing, which is a separate feature.
Validation
cargo test --workspace --no-fail-fastpasses, including all SMAA presets through the noop backend.cargo check --workspacewith the workspace clippy driver and-D warningspasses.Crates/andExamples/.Smart test results
Result: PASS
Scope: orbital_app, orbital_renderer
Reason: directly changed crates
Elapsed: 2m 50s
Workflow run
Overall: 28 tests, 27 passed, 0 failed, 1 skipped
Nextest: 27 tests, 27 passed, 0 failed, 0 skipped
Doctests: 1 tests, 0 passed, 0 failed, 1 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.