fix(android): pass a bool to JValue::Bool #1054
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!1054
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/android-jni-bool"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
jni-sys 0.4 defines jboolean as bool, so setSustainedPerformanceMode no longer accepts the integer literal 1. This fixes the Android build under jni 0.22.
Smart test results
Result: PASS
Scope: orbital_app
Reason: directly changed crates
Elapsed: 3m 22s
Workflow run
Overall: 20 tests, 19 passed, 0 failed, 1 skipped
Nextest: 19 tests, 19 passed, 0 failed, 0 skipped
Doctests: 1 tests, 0 passed, 0 failed, 1 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.