fix(android): pass a bool to JValue::Bool #1054

Merged
SakulFlee merged 1 commit from fix/android-jni-bool into main 2026-11-06 02:18:24 +00:00
Owner

jni-sys 0.4 defines jboolean as bool, so setSustainedPerformanceMode no longer accepts the integer literal 1. This fixes the Android build under jni 0.22.

jni-sys 0.4 defines jboolean as bool, so setSustainedPerformanceMode no longer accepts the integer literal 1. This fixes the Android build under jni 0.22. <!-- Please read and understand every line you submit, verify the build, lints, tests, and affected examples, and remove any AI/model attribution. You own this change and are responsible for its correctness, licensing, security, and follow-up. Delete this note before opening the pull request. -->
fix(android): pass a bool to JValue::Bool
All checks were successful
Lint / lint (pull_request) Successful in 1m11s
PR / test (pull_request) Successful in 3m47s
cb31a121dc
jni-sys 0.4 defines jboolean as bool, so setSustainedPerformanceMode no longer accepts the integer literal 1. This fixes the Android build under jni 0.22.
SakulFlee deleted branch fix/android-jni-bool 2026-11-06 02:18:24 +00:00

Smart test results

Result: PASS

Scope: orbital_app

Reason: directly changed crates

Elapsed: 3m 22s

Workflow run

Overall: 20 tests, 19 passed, 0 failed, 1 skipped

Nextest: 19 tests, 19 passed, 0 failed, 0 skipped
Doctests: 1 tests, 0 passed, 0 failed, 1 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 19 19 0 0 0/1 0.25s
pie showData
    title Nextest outcomes
    "Passed" : 19
pie showData
    title Doctest outcomes
    "Skipped" : 1
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app **Reason:** directly changed crates **Elapsed:** 3m 22s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/1155) **Overall:** 20 tests, 19 passed, 0 failed, 1 skipped **Nextest:** 19 tests, 19 passed, 0 failed, 0 skipped **Doctests:** 1 tests, 0 passed, 0 failed, 1 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 19 | 19 | 0 | 0 | 0/1 | 0.25s | ```mermaid pie showData title Nextest outcomes "Passed" : 19 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 1 ```
Sign in to join this conversation.
No description provided.