SakulFlee/Orbital
Watch
1
0
Fork
You've already forked Orbital
 0
Code Issues 53 Pull requests Projects Releases 5 Packages Wiki Activity Actions

refactor/gltf-texture-take-by-value #697

Closed
SakulFlee wants to merge 3 commits from refactor/gltf-texture-take-by-value into main
pull from: refactor/gltf-texture-take-by-value
merge into: SakulFlee:main
Conversation 1 Commits 3 Files changed 1 +27 -26
SakulFlee commented 2026-07-17 20:03:46 +00:00
Owner
Copy link
No description provided.
refactor: take gltf::image::Data by value in parse_texture
Some checks failed
ci/woodpecker/push/linting Pipeline failed
Details
df1a99c5d8
 
Changed parse_texture, parse_texture_srgb, parse_texture_linear, and
parse_dual_texture to take gltf::image::Data by value instead of by
reference. In the no-alpha path, this avoids cloning data.pixels since
we now own it directly. Call sites clone the texture data once to pass
ownership, making the clone explicit and the ownership model cleaner.
style: auto-format code
All checks were successful
ci/woodpecker/push/linting Pipeline was successful
Details
7c3d278b3d
Merge branch 'main' into refactor/gltf-texture-take-by-value
Some checks failed
PR / lint (pull_request) Failing after 14s
Details
8f6c6d5c27
SakulFlee commented 2026-09-29 03:19:45 +00:00
Author
Owner
Copy link

Superseeded by #834, #835 & #836

Superseeded by #834, #835 & #836
SakulFlee closed this pull request 2026-09-29 03:19:45 +00:00
Some checks are pending
PR / lint (pull_request) Failing after 14s
Details
Lint / *
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Context: Bug
Something isn't working as intended

  
Context: Enhancements
Enhancements of existing features

  
Platform: Android
ONLY if this is platform specific!

  
Platform: Linux
ONLY if this is platform specific!

  
Platform: Web
ONLY if this is platform specific!

  
Platform: Windows
ONLY if this is platform specific!

  
Platform: iOS
ONLY if this is platform specific!

  
Platform: macOS
ONLY if this is platform specific!

  
Target: CI
GitHub Actions / CI related tasks

  
Target: CLI

   
Target: Dependency

   
Target: Engine
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Target: CI
Target: CLI
Target: Dependency
Target: Engine
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
SakulFlee
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
SakulFlee/Orbital!697
No description provided.