SakulFlee/Orbital
1
0
Fork 0
Code Issues 51 Pull requests 24 Projects Releases 1 Packages Wiki Activity

cleanup/panic-to-result #702

Open
SakulFlee wants to merge 2 commits from cleanup/panic-to-result into main
pull from: cleanup/panic-to-result
merge into: SakulFlee:main
Conversation 0 Commits 2 Files changed 2 +68 -33
SakulFlee commented 2026-07-17 22:04:07 +02:00
Owner
Copy link
No description provided.
fix: replace panic! in shader bind group creation with Result errors
Some checks failed
ci/woodpecker/push/linting Pipeline failed
Details
65136ee520
 
The shader module's bind_group method was using panic! and expect()
for recoverable errors (wrong variable type or missing variable).
Now returns proper ShaderError variants (VariableTypeMismatch,
MissingVariable) instead of panicking.
style: auto-format code
Some checks failed
ci/woodpecker/push/linting Pipeline failed
Details
3d431115e3
Some checks are pending
ci/woodpecker/push/linting Pipeline failed
Details
ci/woodpecker/pr/test
Required
ci/woodpecker/pr/linting
Required
Some required checks are missing.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin cleanup/panic-to-result:cleanup/panic-to-result
git switch cleanup/panic-to-result
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Context: Async
Async specific, be it bug or feature

  
Context: Bug
Something isn't working as intended

  
Context: CI
GitHub Actions / CI related tasks

  
Context: Dependencies
Pull requests that update a dependency file

  
Context: Documentation
Improvements or additions to documentation

  
Context: Enhancement
New feature or request

  
Context: Example
Example related issues

  
Context: Macro

   
Context: Runtime
Runtime related issues

  
Difficulty: Easy

   
Difficulty: Hard

   
Difficulty: Medium

   
Platform: Android
ONLY if this is platform specific!

  
Platform: iOS
ONLY if this is platform specific!

  
Platform: Linux
ONLY if this is platform specific!

  
Platform: macOS
ONLY if this is platform specific!

  
Platform: Web
ONLY if this is platform specific!

  
Platform: Windows
ONLY if this is platform specific!

  
Type: Discussion

   
Type: Evaluation
Further evaluation is needed

  
Type: Tracker
Issues acting as trackers; I.e. a combination of issues of the same overall topic.

No labels
Context: Async
Context: Bug
Context: CI
Context: Dependencies
Context: Documentation
Context: Enhancement
Context: Example
Context: Macro
Context: Runtime
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Platform: Android
Platform: iOS
Platform: Linux
Platform: macOS
Platform: Web
Platform: Windows
Type: Discussion
Type: Evaluation
Type: Tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
SakulFlee
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SakulFlee/Orbital!702
No description provided.