SakulFlee/Orbital
1
0
Fork 0
Code Issues 51 Pull requests 24 Projects Releases 1 Packages Wiki Activity

refactor: make shader paths configurable via constants #703

Open
SakulFlee wants to merge 1 commit from cleanup/configurable-shader-paths into main
pull from: cleanup/configurable-shader-paths
merge into: SakulFlee:main
Conversation 0 Commits 1 Files changed 2 +11 -10
SakulFlee commented 2026-07-17 22:04:11 +02:00
Owner
Copy link

Replaced hardcoded shader paths with named constants:

  • ShaderPreprocessor: DEFAULT_SHADER_LIB_PATH (replaces debug/release variants)
  • PBRMaterialShader: DEFAULT_PBR_SHADER_PATH

Added ShaderPreprocessor::new_with_path() to allow custom shader
library paths. Also fixed the release path from lowercase 'shaders'
to proper case 'Shaders'.

Replaced hardcoded shader paths with named constants: - ShaderPreprocessor: DEFAULT_SHADER_LIB_PATH (replaces debug/release variants) - PBRMaterialShader: DEFAULT_PBR_SHADER_PATH Added ShaderPreprocessor::new_with_path() to allow custom shader library paths. Also fixed the release path from lowercase 'shaders' to proper case 'Shaders'.
refactor: make shader paths configurable via constants
All checks were successful
ci/woodpecker/push/linting Pipeline was successful
Details
2c06110c58
 
Replaced hardcoded shader paths with named constants:
- ShaderPreprocessor: DEFAULT_SHADER_LIB_PATH (replaces debug/release variants)
- PBRMaterialShader: DEFAULT_PBR_SHADER_PATH

Added ShaderPreprocessor::new_with_path() to allow custom shader
library paths. Also fixed the release path from lowercase 'shaders'
to proper case 'Shaders'.
Some checks are pending
ci/woodpecker/push/linting Pipeline was successful
Details
ci/woodpecker/pr/test
Required
ci/woodpecker/pr/linting
Required
Some required checks are missing.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin cleanup/configurable-shader-paths:cleanup/configurable-shader-paths
git switch cleanup/configurable-shader-paths
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Context: Async
Async specific, be it bug or feature

  
Context: Bug
Something isn't working as intended

  
Context: CI
GitHub Actions / CI related tasks

  
Context: Dependencies
Pull requests that update a dependency file

  
Context: Documentation
Improvements or additions to documentation

  
Context: Enhancement
New feature or request

  
Context: Example
Example related issues

  
Context: Macro

   
Context: Runtime
Runtime related issues

  
Difficulty: Easy

   
Difficulty: Hard

   
Difficulty: Medium

   
Platform: Android
ONLY if this is platform specific!

  
Platform: iOS
ONLY if this is platform specific!

  
Platform: Linux
ONLY if this is platform specific!

  
Platform: macOS
ONLY if this is platform specific!

  
Platform: Web
ONLY if this is platform specific!

  
Platform: Windows
ONLY if this is platform specific!

  
Type: Discussion

   
Type: Evaluation
Further evaluation is needed

  
Type: Tracker
Issues acting as trackers; I.e. a combination of issues of the same overall topic.

No labels
Context: Async
Context: Bug
Context: CI
Context: Dependencies
Context: Documentation
Context: Enhancement
Context: Example
Context: Macro
Context: Runtime
Difficulty: Easy
Difficulty: Hard
Difficulty: Medium
Platform: Android
Platform: iOS
Platform: Linux
Platform: macOS
Platform: Web
Platform: Windows
Type: Discussion
Type: Evaluation
Type: Tracker
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
SakulFlee
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
SakulFlee/Orbital!703
No description provided.