perf: hoist ECS store lookups outside realize loops #713

Open

SakulFlee wants to merge 1 commit from perf/realize-hoist-store-locks into main

SakulFlee commented

2026-07-17 22:05:05 +02:00

Owner

In realize_cameras and realize_models, get_component_store calls for
dirty/realization flags were inside the per-entity loop, acquiring
a lock and performing a HashMap lookup on each iteration. Now these
stores are looked up once before the loop and reused.

In realize_cameras and realize_models, get_component_store calls for dirty/realization flags were inside the per-entity loop, acquiring a lock and performing a HashMap lookup on each iteration. Now these stores are looked up once before the loop and reused.

SakulFlee self-assigned this

2026-07-17 22:05:05 +02:00

SakulFlee added 1 commit

2026-07-17 22:05:05 +02:00

perf: hoist ECS store lookups outside realize loops

ci/woodpecker/push/linting Pipeline failed

Details

bcfd968182

In realize_cameras and realize_models, get_component_store calls for
dirty/realization flags were inside the per-entity loop, acquiring
a lock and performing a HashMap lookup on each iteration. Now these
stores are looked up once before the loop and reused.

ci/woodpecker/push/linting Pipeline failed

Details

ci/woodpecker/pr/test

Required

ci/woodpecker/pr/linting

Required

This pull request has changes conflicting with the target branch.

Crates/orbital_app/src/systems/realize.rs

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title

Merge pull request 'perf: hoist ECS store lookups outside realize loops' (#713) from perf/realize-hoist-store-locks into main

Merge commit body

Reviewed-on: https://forgejo.sakul-flee.de/SakulFlee/Orbital/pulls/713

Merge pull request 'perf: hoist ECS store lookups outside realize loops' (#713) from perf/realize-hoist-store-locks into main

Reviewed-on: https://forgejo.sakul-flee.de/SakulFlee/Orbital/pulls/713

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin perf/realize-hoist-store-locks:perf/realize-hoist-store-locks

git switch perf/realize-hoist-store-locks

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

SakulFlee/Orbital!713

No description provided.

Rows
Columns