The list_devices() parser used split_whitespace().next() to extract the
device serial from 'adb devices' output. WiFi ADB serials like
'adb-d6260ff205bc-htaRwx (3)._adb-tls-connect._tcp' contain spaces,
causing the serial to be truncated and the device to be silently skipped.

Parse the line by scanning for the device state keyword instead, so the
full serial (including spaces) is captured correctly.

fix: recognize tab separator in adb devices output

CI / lint (pull_request) Failing after 22s

Details

CI / test (pull_request) Has been skipped

Details

ba063b5f3b

The previous fix checked for a space character before the state keyword,
but adb devices uses a tab character to separate the serial from the
state column. This caused WiFi ADB serials (which contain spaces) to
still be silently skipped.

Use is_ascii_whitespace() instead of == b' ' to handle both tabs and
spaces. Also fix the 'no permissions' branch which had the same issue.

SakulFlee merged commit 040f525f6a into main

2026-09-06 14:02:43 +00:00

SakulFlee referenced this pull request from a commit

2026-09-06 14:02:45 +00:00

Merge pull request 'ADB device name splitting bug' (#773) from adb-device-name-split-bug into main