Bug: shader rework broke prelude shaders #780

Merged

SakulFlee merged 30 commits from bug-shader-rework-broke-prelude into main 2026-09-11 20:15:14 +00:00

Conversation 0 Commits 30 Files changed 37 +229 -620

SakulFlee commented 2026-09-10 21:16:03 +00:00

Owner

Copy link

No description provided.

SakulFlee added the

Context: Bug

label 2026-09-10 21:16:03 +00:00

SakulFlee self-assigned this 2026-09-10 21:16:03 +00:00

SakulFlee added 4 commits 2026-09-10 21:16:03 +00:00

Remove redundant prelude node library ... 86bbb7ad77

All 35 nodes in the prelude are also defined in the math and engine
libraries, causing ConflictingNodeName panics at registration time
because the WGSL source differs due to whitespace.

Remove prelude module declaration and re-export a4e5a69d81

Simplify global registry initialization ... 68f245be1e

Start the global NodeRegistry empty instead of preloading the prelude.
Libraries (math, engine, PBR, world-environment) are registered via
register_global_library at engine startup.

Update test to reflect empty global registry ... 0c2609672f

The global_registry_contains_prelude test asserted prelude nodes existed.
Replace with global_registry_starts_empty since the prelude was removed.

forgejo-actions added 1 commit 2026-09-10 21:16:26 +00:00

style: auto-format code 32b029bb30

SakulFlee added 1 commit 2026-09-11 00:05:05 +00:00

Merge branch 'main' into bug-shader-rework-broke-prelude 35efa87e6b

forgejo-actions added 1 commit 2026-09-11 00:11:10 +00:00

fix: auto-fix clippy warnings 6cff9913a0

forgejo-actions added 1 commit 2026-09-11 00:11:29 +00:00

style: auto-format code ce542a8f4a

SakulFlee added 1 commit 2026-09-11 00:43:34 +00:00

Merge branch 'main' into bug-shader-rework-broke-prelude 99f41ade41

SakulFlee added 3 commits 2026-09-11 01:56:28 +00:00

Fix wgsl_shaders tests to use math/engine libraries ... 8dc057e2a8

The global registry is now empty after prelude removal. Update test
helpers to register math, engine, and world-environment libraries
directly instead of relying on the global registry.

Add orbital_shader_math and orbital_shader_engine as dev-dependencies c711cc1f29

Update Cargo.lock a480e03502

SakulFlee added 1 commit 2026-09-11 17:24:21 +00:00

Merge branch 'main' into bug-shader-rework-broke-prelude 217b84a601

SakulFlee added 13 commits 2026-09-11 18:25:26 +00:00

fix: reduce doc list item indentation from 4 to 2 spaces in mode.rs b45b3cad67

fix: use clamp() instead of manual if-else clamping 5f1d58544e

fix: use { *self } in Clone impl for Copy type f7f5e8a188

fix: use &[T] instead of &Vec<T> in function signatures and extend(repeat_n()) for push loop 5b2ac848a4

fix: use if let Some() instead of is_some() + unwrap() 5e0b1b1472

fix: use std::f32::consts::FRAC_1_SQRT_2 instead of approx 0.7071 e4dae1b91b

fix: box TextureDescriptor in VariableType::Texture to reduce enum size 810ad8b86a

fix: use struct literal with ..Default::default() for wireframe_descriptor 383449e58f

fix: use struct literal with ..Default::default() for AppSettings in examples cf29e14977

fix: remove unused started field from LightAnimator and allow dead_code on LightModule 340512803c

fix: allow too_many_arguments for functions with architectural arg counts 5dfb6b5794

fix: allow type_complexity for internal function system types e5188e1466

fix: allow module_inception for ecs module organization 0469a3c5ac

SakulFlee added 1 commit 2026-09-11 18:31:59 +00:00

Format fix cffe710066

SakulFlee added 3 commits 2026-09-11 20:11:30 +00:00

ci: add cargo registry caching to reduce crate downloads in CI ae44b15338

ci: rename ci.yml to pr.yml, lint-only for PRs 7c27578142

ci: add lint and test jobs to release pipeline 3c4aba365f

SakulFlee merged commit bd27f97ec3 into main 2026-09-11 20:15:14 +00:00

SakulFlee referenced this pull request from a commit 2026-09-11 20:15:15 +00:00

Merge pull request 'Bug: shader rework broke prelude shaders' (#780) from bug-shader-rework-broke-prelude into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Context: Bug

Something isn't working as intended

  

Context: Enhancements

Enhancements of existing features

  

Platform: Android

ONLY if this is platform specific!

  

Platform: Linux

ONLY if this is platform specific!

  

Platform: Web

ONLY if this is platform specific!

  

Platform: Windows

ONLY if this is platform specific!

  

Platform: iOS

ONLY if this is platform specific!

  

Platform: macOS

ONLY if this is platform specific!

  

Target: CI

GitHub Actions / CI related tasks

  

Target: CLI

  

Target: Dependency

  

Target: Engine

No labels

Context: Bug

Context: Enhancements

Platform: Android

Platform: Linux

Platform: Web

Platform: Windows

Platform: iOS

Platform: macOS

Target: CI

Target: CLI

Target: Dependency

Target: Engine

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

SakulFlee

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

SakulFlee/Orbital!780

No description provided.