fix(cli): use std::io::IsTerminal for terminal detection #906

Merged
SakulFlee merged 1 commit from fix/cli-windows-isatty into main 2026-10-23 20:00:46 +00:00
Owner

libc::isatty was only available on Unix while the call site was not cfg-gated, breaking Windows builds. Use the standard library's cross-platform IsTerminal and drop the now-unused libc dependency.

libc::isatty was only available on Unix while the call site was not cfg-gated, breaking Windows builds. Use the standard library's cross-platform IsTerminal and drop the now-unused libc dependency. <!-- Please read and understand every line you submit, verify the build, lints, tests, and affected examples, and remove any AI/model attribution. You own this change and are responsible for its correctness, licensing, security, and follow-up. Delete this note before opening the pull request. -->
fix(cli): use std::io::IsTerminal for terminal detection
All checks were successful
Lint / lint (pull_request) Successful in 2m43s
Templates / templates (pull_request) Successful in 4m4s
PR / test (pull_request) Successful in 8m32s
7711c6d6d9
libc::isatty was only available on Unix while the call site was not cfg-gated, breaking Windows builds. Use the standard library's cross-platform IsTerminal and drop the now-unused libc dependency.
SakulFlee deleted branch fix/cli-windows-isatty 2026-10-23 20:00:46 +00:00

Smart test results

Result: PASS

Scope: full workspace

Reason: workspace-level change: Cargo.lock

Elapsed: 6m 58s

Workflow run

Overall: 388 tests, 378 passed, 0 failed, 10 skipped

Nextest: 377 tests, 377 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital 1 1 0 0 - 0.76s
orbital_2d 29 29 0 0 0/1 0.24s
orbital_app 9 9 0 0 0/1 0.07s
orbital_camera 4 4 0 0 - 0.03s
orbital_core 2 2 0 0 - 0.02s
orbital_debug_render 0 0 0 0 0/1 0.00s
orbital_debug_ui 28 28 0 0 0/1 0.24s
orbital_ecs 114 114 0 0 0/2 1.07s
orbital_ecs_bridge 33 33 0 0 - 0.28s
orbital_file_manager 5 5 0 0 - 0.05s
orbital_iced 15 15 0 0 - 0.15s
orbital_importer_gltf 13 13 0 0 - 0.23s
orbital_input 10 10 0 0 - 0.12s
orbital_light 6 6 0 0 - 0.07s
orbital_macros 0 0 0 0 0/1 0.00s
orbital_math 4 4 0 0 - 0.04s
orbital_procgeo 2 2 0 0 - 0.02s
orbital_resources 18 18 0 0 - 0.23s
orbital_shader_core 0 0 0 0 1/1 0.00s
orbital_shader_preprocessor 12 12 0 0 - 0.10s
orbital_shadow 3 3 0 0 - 0.03s
orbital_text 14 14 0 0 0/1 0.57s
orbital_texture 9 9 0 0 - 0.12s
orbital_touch_ui 1 1 0 0 0/1 0.02s
orbital_ui 32 32 0 0 0/1 0.34s
orbital_world_environment 13 13 0 0 - 0.11s
pie showData
    title Nextest outcomes
    "Passed" : 377
pie showData
    title Doctest outcomes
    "Passed" : 1
    "Skipped" : 10
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_ecs", "orbital", "orbital_text", "orbital_ui", "orbital_ecs_bridge", "orbital_2d", "orbital_debug_ui", "orbital_resources"]
    y-axis "Seconds" 0 --> 1.1
    bar [1.07, 0.76, 0.57, 0.34, 0.28, 0.24, 0.24, 0.23]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** full workspace **Reason:** workspace-level change: Cargo.lock **Elapsed:** 6m 58s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/472) **Overall:** 388 tests, 378 passed, 0 failed, 10 skipped **Nextest:** 377 tests, 377 passed, 0 failed, 0 skipped **Doctests:** 11 tests, 1 passed, 0 failed, 10 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital | 1 | 1 | 0 | 0 | - | 0.76s | | orbital_2d | 29 | 29 | 0 | 0 | 0/1 | 0.24s | | orbital_app | 9 | 9 | 0 | 0 | 0/1 | 0.07s | | orbital_camera | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_core | 2 | 2 | 0 | 0 | - | 0.02s | | orbital_debug_render | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_debug_ui | 28 | 28 | 0 | 0 | 0/1 | 0.24s | | orbital_ecs | 114 | 114 | 0 | 0 | 0/2 | 1.07s | | orbital_ecs_bridge | 33 | 33 | 0 | 0 | - | 0.28s | | orbital_file_manager | 5 | 5 | 0 | 0 | - | 0.05s | | orbital_iced | 15 | 15 | 0 | 0 | - | 0.15s | | orbital_importer_gltf | 13 | 13 | 0 | 0 | - | 0.23s | | orbital_input | 10 | 10 | 0 | 0 | - | 0.12s | | orbital_light | 6 | 6 | 0 | 0 | - | 0.07s | | orbital_macros | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_math | 4 | 4 | 0 | 0 | - | 0.04s | | orbital_procgeo | 2 | 2 | 0 | 0 | - | 0.02s | | orbital_resources | 18 | 18 | 0 | 0 | - | 0.23s | | orbital_shader_core | 0 | 0 | 0 | 0 | 1/1 | 0.00s | | orbital_shader_preprocessor | 12 | 12 | 0 | 0 | - | 0.10s | | orbital_shadow | 3 | 3 | 0 | 0 | - | 0.03s | | orbital_text | 14 | 14 | 0 | 0 | 0/1 | 0.57s | | orbital_texture | 9 | 9 | 0 | 0 | - | 0.12s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.02s | | orbital_ui | 32 | 32 | 0 | 0 | 0/1 | 0.34s | | orbital_world_environment | 13 | 13 | 0 | 0 | - | 0.11s | ```mermaid pie showData title Nextest outcomes "Passed" : 377 ``` ```mermaid pie showData title Doctest outcomes "Passed" : 1 "Skipped" : 10 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_ecs", "orbital", "orbital_text", "orbital_ui", "orbital_ecs_bridge", "orbital_2d", "orbital_debug_ui", "orbital_resources"] y-axis "Seconds" 0 --> 1.1 bar [1.07, 0.76, 0.57, 0.34, 0.28, 0.24, 0.24, 0.23] ```
Sign in to join this conversation.
No description provided.