fix(ci): pin Rust toolchain and align lint workflows #911

Merged
SakulFlee merged 2 commits from fix/ci-toolchain-drift into main 2026-10-24 02:33:45 +00:00
Owner

Clippy 1.99 added GOLDEN_RATIO to approx_constant, which broke the GitHub lint job on const PHI: f32 = 1.618_034. The Nix devshell and Forgejo CI image were still on older toolchains, so they missed it.

  • Use f32::consts::GOLDEN_RATIO and raise the workspace MSRV to 1.94.
  • Pin Rust 1.99.0 in rust-toolchain.toml and consume it from Nix, GitHub, Forgejo, and TeamCity.
  • Rebuild the CI image with the pinned toolchain and refresh it monthly.
  • Run lint on pushes to main and use the same strict commands everywhere.
  • Restrict Forgejo lint auto-fixes to pull requests.
Clippy 1.99 added GOLDEN_RATIO to approx_constant, which broke the GitHub lint job on `const PHI: f32 = 1.618_034`. The Nix devshell and Forgejo CI image were still on older toolchains, so they missed it. - Use `f32::consts::GOLDEN_RATIO` and raise the workspace MSRV to 1.94. - Pin Rust 1.99.0 in rust-toolchain.toml and consume it from Nix, GitHub, Forgejo, and TeamCity. - Rebuild the CI image with the pinned toolchain and refresh it monthly. - Run lint on pushes to main and use the same strict commands everywhere. - Restrict Forgejo lint auto-fixes to pull requests. <!-- Please read and understand every line you submit, verify the build, lints, tests, and affected examples, and remove any AI/model attribution. You own this change and are responsible for its correctness, licensing, security, and follow-up. Delete this note before opening the pull request. -->
fix(ci): pin Rust toolchain and align lint workflows
All checks were successful
Lint / lint (pull_request) Successful in 3m44s
Templates / templates (pull_request) Successful in 4m49s
PR / test (pull_request) Successful in 11m37s
edbdcc9a32
Clippy 1.99 added GOLDEN_RATIO to approx_constant, which broke the GitHub lint job on `const PHI: f32 = 1.618_034`. The Nix devshell and Forgejo CI image were still on older toolchains, so they missed it.

- Use `f32::consts::GOLDEN_RATIO` and raise the workspace MSRV to 1.94.
- Pin Rust 1.99.0 in rust-toolchain.toml and consume it from Nix, GitHub, Forgejo, and TeamCity.
- Rebuild the CI image with the pinned toolchain and refresh it monthly.
- Run lint on pushes to main and use the same strict commands everywhere.
- Restrict Forgejo lint auto-fixes to pull requests.

Smart test results

Result: PASS

Scope: full workspace

Reason: workspace-level change: .forgejo/ci/Dockerfile

Elapsed: 8m 5s

Workflow run

Overall: 388 tests, 378 passed, 0 failed, 10 skipped

Nextest: 377 tests, 377 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital 1 1 0 0 - 0.72s
orbital_2d 29 29 0 0 0/1 0.22s
orbital_app 9 9 0 0 0/1 0.06s
orbital_camera 4 4 0 0 - 0.03s
orbital_core 2 2 0 0 - 0.02s
orbital_debug_render 0 0 0 0 0/1 0.00s
orbital_debug_ui 28 28 0 0 0/1 0.27s
orbital_ecs 114 114 0 0 0/2 0.99s
orbital_ecs_bridge 33 33 0 0 - 0.25s
orbital_file_manager 5 5 0 0 - 0.06s
orbital_iced 15 15 0 0 - 0.15s
orbital_importer_gltf 13 13 0 0 - 0.22s
orbital_input 10 10 0 0 - 0.07s
orbital_light 6 6 0 0 - 0.04s
orbital_macros 0 0 0 0 0/1 0.00s
orbital_math 4 4 0 0 - 0.03s
orbital_procgeo 2 2 0 0 - 0.02s
orbital_resources 18 18 0 0 - 0.27s
orbital_shader_core 0 0 0 0 1/1 0.00s
orbital_shader_preprocessor 12 12 0 0 - 0.08s
orbital_shadow 3 3 0 0 - 0.02s
orbital_text 14 14 0 0 0/1 0.46s
orbital_texture 9 9 0 0 - 0.07s
orbital_touch_ui 1 1 0 0 0/1 0.01s
orbital_ui 32 32 0 0 0/1 0.21s
orbital_world_environment 13 13 0 0 - 0.08s
pie showData
    title Nextest outcomes
    "Passed" : 377
pie showData
    title Doctest outcomes
    "Passed" : 1
    "Skipped" : 10
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_ecs", "orbital", "orbital_text", "orbital_resources", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_2d", "orbital_importer_gltf"]
    y-axis "Seconds" 0 --> 1
    bar [0.99, 0.72, 0.46, 0.27, 0.27, 0.25, 0.22, 0.22]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** full workspace **Reason:** workspace-level change: .forgejo/ci/Dockerfile **Elapsed:** 8m 5s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/499) **Overall:** 388 tests, 378 passed, 0 failed, 10 skipped **Nextest:** 377 tests, 377 passed, 0 failed, 0 skipped **Doctests:** 11 tests, 1 passed, 0 failed, 10 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital | 1 | 1 | 0 | 0 | - | 0.72s | | orbital_2d | 29 | 29 | 0 | 0 | 0/1 | 0.22s | | orbital_app | 9 | 9 | 0 | 0 | 0/1 | 0.06s | | orbital_camera | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_core | 2 | 2 | 0 | 0 | - | 0.02s | | orbital_debug_render | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_debug_ui | 28 | 28 | 0 | 0 | 0/1 | 0.27s | | orbital_ecs | 114 | 114 | 0 | 0 | 0/2 | 0.99s | | orbital_ecs_bridge | 33 | 33 | 0 | 0 | - | 0.25s | | orbital_file_manager | 5 | 5 | 0 | 0 | - | 0.06s | | orbital_iced | 15 | 15 | 0 | 0 | - | 0.15s | | orbital_importer_gltf | 13 | 13 | 0 | 0 | - | 0.22s | | orbital_input | 10 | 10 | 0 | 0 | - | 0.07s | | orbital_light | 6 | 6 | 0 | 0 | - | 0.04s | | orbital_macros | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_math | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_procgeo | 2 | 2 | 0 | 0 | - | 0.02s | | orbital_resources | 18 | 18 | 0 | 0 | - | 0.27s | | orbital_shader_core | 0 | 0 | 0 | 0 | 1/1 | 0.00s | | orbital_shader_preprocessor | 12 | 12 | 0 | 0 | - | 0.08s | | orbital_shadow | 3 | 3 | 0 | 0 | - | 0.02s | | orbital_text | 14 | 14 | 0 | 0 | 0/1 | 0.46s | | orbital_texture | 9 | 9 | 0 | 0 | - | 0.07s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.01s | | orbital_ui | 32 | 32 | 0 | 0 | 0/1 | 0.21s | | orbital_world_environment | 13 | 13 | 0 | 0 | - | 0.08s | ```mermaid pie showData title Nextest outcomes "Passed" : 377 ``` ```mermaid pie showData title Doctest outcomes "Passed" : 1 "Skipped" : 10 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_ecs", "orbital", "orbital_text", "orbital_resources", "orbital_debug_ui", "orbital_ecs_bridge", "orbital_2d", "orbital_importer_gltf"] y-axis "Seconds" 0 --> 1 bar [0.99, 0.72, 0.46, 0.27, 0.27, 0.25, 0.22, 0.22] ```
fix(ci): build CI image on the docker runner
All checks were successful
Lint / lint (pull_request) Successful in 3m16s
Templates / templates (pull_request) Successful in 3m30s
PR / test (pull_request) Successful in 10m26s
caa1cc1d4c
The migrated runner's job containers are unprivileged, so Buildah's user-namespace setup fails with EPERM. Build the CI image with Docker on the docker runner and push to the public Forgejo registry.

Also point the lint auto-fix push at GITHUB_SERVER_URL instead of the retired in-cluster HTTP host.
SakulFlee deleted branch fix/ci-toolchain-drift 2026-10-24 02:33:46 +00:00
Sign in to join this conversation.
No description provided.