fix(lint): remove orphaned iced workspace lint config #929

Merged
SakulFlee merged 1 commit from fix/914-remove-leftover-lints into main 2026-10-25 00:08:49 +00:00
Owner

The [workspace.lints] block was inherited from the iced fork when the workspaces were merged, but no Orbital crate opted in with [lints] workspace = true, so the policy was inert and produced deprecation and missing-inheritance warnings.

Rely on the standard clippy::all set enforced by CI instead.

Closes #914

The [workspace.lints] block was inherited from the iced fork when the workspaces were merged, but no Orbital crate opted in with [lints] workspace = true, so the policy was inert and produced deprecation and missing-inheritance warnings. Rely on the standard clippy::all set enforced by CI instead. Closes #914 <!-- Please read and understand every line you submit, verify the build, lints, tests, and affected examples, and remove any AI/model attribution. You own this change and are responsible for its correctness, licensing, security, and follow-up. Delete this note before opening the pull request. -->
fix(lint): remove orphaned iced workspace lint config
All checks were successful
Lint / lint (pull_request) Successful in 2m11s
Templates / templates (pull_request) Successful in 3m30s
PR / test (pull_request) Successful in 17m1s
fbad553d0e
The [workspace.lints] block was inherited from the iced fork when the workspaces were merged, but no Orbital crate opted in with [lints] workspace = true, so the policy was inert and produced deprecation and missing-inheritance warnings.

Rely on the standard clippy::all set enforced by CI instead.

Closes #914

Smart test results

Result: PASS

Scope: full workspace

Reason: workspace-level change: Cargo.toml

Elapsed: 14m 33s

Workflow run

Overall: 404 tests, 394 passed, 0 failed, 10 skipped

Nextest: 393 tests, 393 passed, 0 failed, 0 skipped
Doctests: 11 tests, 1 passed, 0 failed, 10 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital 1 1 0 0 - 0.14s
orbital_2d 29 29 0 0 0/1 0.22s
orbital_app 9 9 0 0 0/1 0.07s
orbital_camera 4 4 0 0 - 0.04s
orbital_core 2 2 0 0 - 0.01s
orbital_debug_render 0 0 0 0 0/1 0.00s
orbital_debug_ui 38 38 0 0 0/1 0.29s
orbital_ecs 114 114 0 0 0/2 0.92s
orbital_ecs_bridge 37 37 0 0 - 0.32s
orbital_file_manager 5 5 0 0 - 0.04s
orbital_iced 16 16 0 0 - 0.14s
orbital_importer_gltf 13 13 0 0 - 0.20s
orbital_input 11 11 0 0 - 0.09s
orbital_light 6 6 0 0 - 0.05s
orbital_macros 0 0 0 0 0/1 0.00s
orbital_math 4 4 0 0 - 0.03s
orbital_procgeo 2 2 0 0 - 0.01s
orbital_resources 18 18 0 0 - 0.18s
orbital_shader_core 0 0 0 0 1/1 0.00s
orbital_shader_preprocessor 12 12 0 0 - 0.09s
orbital_shadow 3 3 0 0 - 0.02s
orbital_text 14 14 0 0 0/1 0.52s
orbital_texture 9 9 0 0 - 0.08s
orbital_touch_ui 1 1 0 0 0/1 0.01s
orbital_ui 32 32 0 0 0/1 0.25s
orbital_world_environment 13 13 0 0 - 0.09s
pie showData
    title Nextest outcomes
    "Passed" : 393
pie showData
    title Doctest outcomes
    "Passed" : 1
    "Skipped" : 10
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_ecs", "orbital_text", "orbital_ecs_bridge", "orbital_debug_ui", "orbital_ui", "orbital_2d", "orbital_importer_gltf", "orbital_resources"]
    y-axis "Seconds" 0 --> 1
    bar [0.92, 0.52, 0.32, 0.29, 0.25, 0.22, 0.20, 0.18]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** full workspace **Reason:** workspace-level change: Cargo.toml **Elapsed:** 14m 33s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/583) **Overall:** 404 tests, 394 passed, 0 failed, 10 skipped **Nextest:** 393 tests, 393 passed, 0 failed, 0 skipped **Doctests:** 11 tests, 1 passed, 0 failed, 10 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital | 1 | 1 | 0 | 0 | - | 0.14s | | orbital_2d | 29 | 29 | 0 | 0 | 0/1 | 0.22s | | orbital_app | 9 | 9 | 0 | 0 | 0/1 | 0.07s | | orbital_camera | 4 | 4 | 0 | 0 | - | 0.04s | | orbital_core | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_debug_render | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_debug_ui | 38 | 38 | 0 | 0 | 0/1 | 0.29s | | orbital_ecs | 114 | 114 | 0 | 0 | 0/2 | 0.92s | | orbital_ecs_bridge | 37 | 37 | 0 | 0 | - | 0.32s | | orbital_file_manager | 5 | 5 | 0 | 0 | - | 0.04s | | orbital_iced | 16 | 16 | 0 | 0 | - | 0.14s | | orbital_importer_gltf | 13 | 13 | 0 | 0 | - | 0.20s | | orbital_input | 11 | 11 | 0 | 0 | - | 0.09s | | orbital_light | 6 | 6 | 0 | 0 | - | 0.05s | | orbital_macros | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_math | 4 | 4 | 0 | 0 | - | 0.03s | | orbital_procgeo | 2 | 2 | 0 | 0 | - | 0.01s | | orbital_resources | 18 | 18 | 0 | 0 | - | 0.18s | | orbital_shader_core | 0 | 0 | 0 | 0 | 1/1 | 0.00s | | orbital_shader_preprocessor | 12 | 12 | 0 | 0 | - | 0.09s | | orbital_shadow | 3 | 3 | 0 | 0 | - | 0.02s | | orbital_text | 14 | 14 | 0 | 0 | 0/1 | 0.52s | | orbital_texture | 9 | 9 | 0 | 0 | - | 0.08s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.01s | | orbital_ui | 32 | 32 | 0 | 0 | 0/1 | 0.25s | | orbital_world_environment | 13 | 13 | 0 | 0 | - | 0.09s | ```mermaid pie showData title Nextest outcomes "Passed" : 393 ``` ```mermaid pie showData title Doctest outcomes "Passed" : 1 "Skipped" : 10 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_ecs", "orbital_text", "orbital_ecs_bridge", "orbital_debug_ui", "orbital_ui", "orbital_2d", "orbital_importer_gltf", "orbital_resources"] y-axis "Seconds" 0 --> 1 bar [0.92, 0.52, 0.32, 0.29, 0.25, 0.22, 0.20, 0.18] ```
SakulFlee deleted branch fix/914-remove-leftover-lints 2026-10-25 00:08:49 +00:00
Sign in to join this conversation.
No description provided.