perf(renderer): record legacy overlays in the main submission #963

Merged
SakulFlee merged 1 commit from perf/renderer-overlay-submit into main 2026-10-28 23:25:53 +00:00
Owner

Summary

Collapses legacy overlay rendering into the main scene submission.

  • Renderer::render now accepts an overlay-recording callback and executes it after the scene graph, before timestamp resolution and submission.
  • RenderOverlayContext exposes the shared command encoder for legacy overlays; LayerRenderer implementations receive None and keep ownership of their submission.
  • Updated the in-tree legacy overlays: 2D shape overlays, debug render overlay, and touch joystick.
  • The runtime records all legacy overlays into one main submit and only iced remains a separate submit.
  • Kept the overlay CPU timing measurement around recording.

Validation

  • cargo test --workspace --no-fail-fast passes.
  • cargo check --workspace with the workspace clippy driver and -D warnings passes.
  • Rust formatting checks pass across Crates/ and Examples/.
  • Visual verification still needs a display/GPU machine; this environment cannot render a frame.
## Summary Collapses legacy overlay rendering into the main scene submission. - `Renderer::render` now accepts an overlay-recording callback and executes it after the scene graph, before timestamp resolution and submission. - `RenderOverlayContext` exposes the shared command encoder for legacy overlays; `LayerRenderer` implementations receive `None` and keep ownership of their submission. - Updated the in-tree legacy overlays: 2D shape overlays, debug render overlay, and touch joystick. - The runtime records all legacy overlays into one main submit and only iced remains a separate submit. - Kept the overlay CPU timing measurement around recording. ## Validation - `cargo test --workspace --no-fail-fast` passes. - `cargo check --workspace` with the workspace clippy driver and `-D warnings` passes. - Rust formatting checks pass across `Crates/` and `Examples/`. - Visual verification still needs a display/GPU machine; this environment cannot render a frame.
perf(renderer): record legacy overlays in the main submission
All checks were successful
Lint / lint (pull_request) Successful in 1m19s
PR / test (pull_request) Successful in 4m48s
Templates / templates (pull_request) Successful in 3m57s
13d9aa7574

Smart test results

Result: PASS

Scope: orbital_app, orbital_debug_render, orbital_renderer, orbital_touch_ui

Reason: directly changed crates

Elapsed: 4m 16s

Workflow run

Overall: 26 tests, 23 passed, 0 failed, 3 skipped

Nextest: 23 tests, 23 passed, 0 failed, 0 skipped
Doctests: 3 tests, 0 passed, 0 failed, 3 skipped

Outcome charts are split between nextest and doctests. The timing chart covers nextest only.

Crate Nextest Passed Failed Skipped Doctests Time
orbital_app 10 10 0 0 0/1 0.16s
orbital_debug_render 0 0 0 0 0/1 0.00s
orbital_renderer 12 12 0 0 - 0.16s
orbital_touch_ui 1 1 0 0 0/1 0.01s
pie showData
    title Nextest outcomes
    "Passed" : 23
pie showData
    title Doctest outcomes
    "Skipped" : 3
xychart-beta
    title "Slowest crates (nextest seconds)"
    x-axis ["orbital_app", "orbital_renderer", "orbital_touch_ui"]
    y-axis "Seconds" 0 --> 1
    bar [0.16, 0.16, 0.01]
<!-- orbital-ci-test-results --> ## Smart test results **Result:** PASS **Scope:** orbital_app, orbital_debug_render, orbital_renderer, orbital_touch_ui **Reason:** directly changed crates **Elapsed:** 4m 16s [Workflow run](https://forgejo.sakul-flee.de/SakulFlee/Orbital/actions/runs/815) **Overall:** 26 tests, 23 passed, 0 failed, 3 skipped **Nextest:** 23 tests, 23 passed, 0 failed, 0 skipped **Doctests:** 3 tests, 0 passed, 0 failed, 3 skipped _Outcome charts are split between nextest and doctests. The timing chart covers nextest only._ | Crate | Nextest | Passed | Failed | Skipped | Doctests | Time | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | orbital_app | 10 | 10 | 0 | 0 | 0/1 | 0.16s | | orbital_debug_render | 0 | 0 | 0 | 0 | 0/1 | 0.00s | | orbital_renderer | 12 | 12 | 0 | 0 | - | 0.16s | | orbital_touch_ui | 1 | 1 | 0 | 0 | 0/1 | 0.01s | ```mermaid pie showData title Nextest outcomes "Passed" : 23 ``` ```mermaid pie showData title Doctest outcomes "Skipped" : 3 ``` ```mermaid xychart-beta title "Slowest crates (nextest seconds)" x-axis ["orbital_app", "orbital_renderer", "orbital_touch_ui"] y-axis "Seconds" 0 --> 1 bar [0.16, 0.16, 0.01] ```
SakulFlee deleted branch perf/renderer-overlay-submit 2026-10-28 23:25:54 +00:00
Sign in to join this conversation.
No description provided.