perf(renderer): record legacy overlays in the main submission #963
No reviewers
Labels
No labels
Context: Bug
Context: Enhancements
Platform: Android
Platform: Linux
Platform: Web
Platform: Windows
Platform: iOS
Platform: macOS
Release
Target: CI
Target: CLI
Target: Dependency
Target: Engine
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
SakulFlee/Orbital!963
Loading…
Reference in a new issue
No description provided.
Delete branch "perf/renderer-overlay-submit"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Collapses legacy overlay rendering into the main scene submission.
Renderer::rendernow accepts an overlay-recording callback and executes it after the scene graph, before timestamp resolution and submission.RenderOverlayContextexposes the shared command encoder for legacy overlays;LayerRendererimplementations receiveNoneand keep ownership of their submission.Validation
cargo test --workspace --no-fail-fastpasses.cargo check --workspacewith the workspace clippy driver and-D warningspasses.Crates/andExamples/.Smart test results
Result: PASS
Scope: orbital_app, orbital_debug_render, orbital_renderer, orbital_touch_ui
Reason: directly changed crates
Elapsed: 4m 16s
Workflow run
Overall: 26 tests, 23 passed, 0 failed, 3 skipped
Nextest: 23 tests, 23 passed, 0 failed, 0 skipped
Doctests: 3 tests, 0 passed, 0 failed, 3 skipped
Outcome charts are split between nextest and doctests. The timing chart covers nextest only.